3.0.0 Bug Report Thread

<baris>

@btc like @julian mentioned these routes got replaced with the /me prefix, so they would be.
/me/bookmarks and /me/watched

btc

When trying to visit the "API Access" menu, I get the following error:

This is a bit of a disaster as now, none of our membership automations etc will work because I can't configure the API settings!

Full error from console is:

2023-05-12T06:37:30.401Z [4567/91921] - error: GET /api/admin/settings/api?_=1683873301366
TypeError: Cannot read properties of undefined (reading 'map')
    at settingsController.api (/usr/bin/nodebb/src/controllers/admin/settings.js:115:52)
    at async /usr/bin/nodebb/src/routes/helpers.js:74:5

It's saying "tokens" is undefined within the following function:

settingsController.api = async (req, res) => {
        const { tokens } = await meta.settings.get('core.api');
        const scores = await api.utils.getLastSeen(tokens.map(t => t.token));

        const [lastSeen, lastSeenISO] = tokens.reduce((memo, cur, idx) => {
                memo[0][cur.token] = scores[idx];
                memo[1][cur.token] = new Date(scores[idx]).toISOString();
                return memo;
        }, [{}, {}]);

        res.render('admin/settings/api', { lastSeen, lastSeenISO });
};

I have worked around it by changing the line to:

const { tokens = [] } = await meta.settings.get('core.api');

I don't know yet whether there will be any knock-on effects!

<baris>

@btc please open an issue on our github. Add your nodebb version as well.

<baris>

@btc released 3.1.2 with the fix, try on that version. Thanks for reporting.

NikolaiPatrushev

I use latest tor browser and upgraded nodebb engine to 3.1.3 recently released version.
I am experience problems with CORS, can somebody help?

I am getting error socket.io/?EIO=4&transport=polling&t= 403 Forbidden
My node server somehow refuses to authorize it socket.io request .

brazzerstop

@NikolaiPatrushev are you have this socket error if use this onion mirror?
https://community.nodebb.org/topic/16981/nodebb-in-tor-works/3

I don't know, but maybe solution for this sockets problem in here: https://community.nodebb.org/topic/13388/faq-websockets-not-working-due-to-misconfigured-origins

NikolaiPatrushev

look what now my server saying
info: [socket.io] Restricting access to origin: i have ommited full address .onion:*
And i still receive same failure message

403 means that my server recognise the request, but for some unknow to me reason it refuse to forward further.

NikolaiPatrushev

it got even worse, i can login, but any changes in admin preferences are not saved, devs please fix this bug or provide workaround.

PitaJ

@NikolaiPatrushev did you check the websockets FAQ linked above?

NikolaiPatrushev

@PitaJ Yes, this did not worked for me.
I run Nginx as reverse proxy with the setup from the nodebb docu, i have SSL certificate which works in tor.
What i need that,that somebody show me the example configs so that i would test it in my environment.
Both for Nginx and the nodebb and the tor.
Or somebody should tell me why all those /socket.io/?EIO=4 403 Forbidden responses are generated and why csrf missing?

inspiring

@baris
َfter updating to v3.1.3:
When I change the language the time of writing posts in the topic is not shown, when replying to the topic
But if it is replied to another post, it will show the time
When I change to English it shows the time

I tried it with the same conditions in your forum but it is correct here, this shows that there is no problem with the translation
Why do you think this problem has arisen in our forum?

<baris>

Which language is it? It might not have the correct translations.

inspiring

@baris
No, the translation is correct because it shows the time in the same language in your forum

<baris>

@inspiring give me a link to a post that has the problem. If it works here then you are probably missing some translations. Those translations are a little complex, they need to be translated correctly without breaking the markup.

"wrote-ago": "wrote <a href=\"%1\" class=\"timeago text-muted\" title=\"%2\"></a>",
"wrote-on": "wrote on <a href=\"%1\" class=\"timeago text-muted\" title=\"%2\"></a>",
"replied-to-user-ago": "replied to <a component=\"post/parent\" data-topid=\"%1\" href=\"%2\">%3</a> <a href=\"%4\" class=\"timeago text-muted\" title=\"%5\"></a>",
"replied-to-user-on": "replied to <a component=\"post/parent\" data-topid=\"%1\" href=\"%2\">%3</a> on <a hrf=\"%4\" class=\"timeago text-muted\" title=\"%5\"></a>",

inspiring

@baris
could you open a chat with me?

NikolaiPatrushev

Ok on 3.1.2 everything works!

brazzerstop

Hey guys!

Today forum was updated to version 3.1.4 and I noticed this error in the event journal after rebooting, I hope this is not critical?

2023-05-20T10:46:05.069Z [4567/3445] - [32minfo[39m: [app] Shutdown complete.
2023-05-20T10:46:06.027Z [4567/3601] - [32minfo[39m: Initializing NodeBB v3.1.4 https://example.com
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at process.target._send (node:internal/child_process:874:20)
    at process.target.send (node:internal/child_process:747:19)
    at process.<anonymous> (/var/www/nodebb/src/meta/minifier.js:118:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Emitted 'error' event on process instance at:
    at node:internal/child_process:878:39
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}
2023-05-20T10:46:09.048Z [4567/3601] - [32minfo[39m: [socket.io] Restricting access to origin: https://example.com:*

After restart mongo I don't view this error

+ Bootstrap

2023-05-20T11:01:29.875Z [4567/4265] - [32minfo[39m: 🔗 Canonical URL: https://example.com
DEPRECATION WARNING on line 68, column 52 of ../../node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
68 │ $nav-link-padding-y:                .5rem !default !default;
   │                                                    ^^^^^^^^
   ╵

DEPRECATION WARNING on line 70, column 56 of ../../node_modules/bootswatch/dist/flatly/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
70 │ $nav-link-disabled-color:           $gray-600 !default !default;
   │                                                        ^^^^^^^^
   ╵

DEPRECATION WARNING on line 79, column 60 of ../../node_modules/bootswatch/dist/litera/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
79 │ $input-group-addon-bg:                  $gray-200 !default !default;
   │                                                            ^^^^^^^^
   ╵

WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-control.scss 40:7  @import
    bootstrap/scss/_forms.scss 3:9                                   @import
    - 18:9                                                           root stylesheet

WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-select.scss 31:7  @import
    bootstrap/scss/_forms.scss 4:9                                  @import
    - 18:9                                                          root stylesheet

DEPRECATION WARNING on line 62, column 208 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
62 │ $font-family-sans-serif:      "Source Sans Pro", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol" !default !default;
   │                                                                                                                                                                                                                ^^^^^^^^
   ╵

DEPRECATION WARNING on line 116, column 63 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
    ╷
116 │ $navbar-light-color:                rgba($black, .4) !default !default;
    │                                                               ^^^^^^^^
    ╵

DEPRECATION WARNING on line 117, column 63 of ../../node_modules/bootswatch/dist/solar/_variables.scss: 
!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
    ╷
117 │ $navbar-light-active-color:         rgba($black, .7) !default !default;
    │                                                               ^^^^^^^^
    ╵

+ FontAwesome

https://community.nodebb.org/topic/12809/add-icons-from-fontawesome-to-icons-list-on-nodebb/17?_=1684599217700

+ Topics Thumbnail

Please add setting in privileges page to allow upload topic thumbnails only for users from some group.

On the /settings/uploads settings admin can only enable/disable thumbnails upload for the all users, so if disable it, admins can't upload thumbnails too.

And add sort label on users page...

ScreenShot 2023-05-20 в 19.29.25.png

<baris>

The bootswatch warnings are fixed in the dependency https://github.com/thomaspark/bootswatch/pull/1246

NikolaiPatrushev

Let me confirm that the latest version of 3.1.4 works in tor too.

brazzerstop

Quote button not work for me on iPad, Safari.
When I click on the button nothing happens.