template.js not executed

[Bejan]

Using this setup https://community.nodebb.org/topic/16017/theme-quickstart-template-created-is-found-no-404-but-not-rendered/6# . However, the javascript in the associated mynewtemplate.js file is not executed.

Console shows no error and the mynewtemplate.js gets loaded as assets/src/client/mynewtemplate.js (visible in Sources).

In plugin.js the config is ../client/mynewtemplate.js. The prefix ../ resolves the path to assets/src/client instead of assets/src/modules/client but what is the reasoning behind this?

Also, I tried using pure JS instead of jQuery in mynewtemplate.js:

document.getElementById('last-p').innerHTML = 'hello world';

Still no joy. No "hello world" in <p> tag.

[PitaJ]

You really need to share all of the modifications you've made. Have you added the file to plugin.json?

[baris]

Keep in mind the mynewtemplate.js will be loaded if the template name is also mynewtemplate.tpl Once that page is rendered it will try to load the requirejs module forum/mynewtemplate

[Bejan]

@pitaj

{¬                                                                                                                                      
  "id": "nodebb-theme-my-forum",¬                                                                                                     
  "hooks": [¬                                                                                                                         
    { "hook": "filter:widgets.getAreas", "method": "defineWidgetAreas" },¬                                                                { "hook": "filter:config.get", "method": "getThemeConfig" },¬                                                                     
    { "hook": "static:app.load", "method": "init" },¬                                                                                 
    { "hook": "filter:admin.header.build", "method": "addAdminNavigation" },¬                                                         
    { "hook": "filter:topic.build", "method": "addUserToTopic" }¬                                                                     
  ],¬                                                                                                                                 
  "scripts": [¬                                                                                                                       
    "public/my-forum.js",¬                                                                                                            
    "public/modules/autohidingnavbar.js",¬                                                                                            
    "public/modules/quickreply.js"¬                                                                                                   
  ],¬                                                                                                                                 
  "staticDirs": {¬                                                                                                                    
    "static": "./static"¬                                                                                                             
  },¬                                                                                                                                 
  "modules": {¬                                                                                                                       
    "pulling.js": "node_modules/pulling/build/pulling-drawer.js",¬                                                                    
    "../client/mynewtemplate.js": "./static/lib/mynewtemplate.js"¬                                                                                                                                                                
  },¬                                                                                                                                 
  "acpScripts": [¬                                                                                                                    
    "public/admin.js"¬                                                                                                                
  ],¬                                                                                                                                 
  "languages": "languages"¬                                                                                                           
}

[Bejan]

@baris said in template.js not executed:

Keep in mind the mynewtemplate.js will be loaded if the template name is also mynewtemplate.tpl

That is how I figured it would work. It seems not to be working (like this), though.

Once that page is rendered it will try to load the requirejs module forum/mynewtemplate

Do you mean, once mynewtemplate.tpl is rendered a file called mynewtemplate.js will be loaded by requirejs? I expected this to be working, something seems amiss though. Where should I start looking?

Thank you,

[Bejan]

That's weird. The js file gets loaded and is present in the sources tab in dev console. It's just not executed in the rendered template. Executing the js code in the console manually yields the expected result in the rendered template, though.

Any ideas how to get the js code executed?

Thanks.

[PitaJ]

What are the contents of that file? Have you tried just mynewtemplate.js instead of ../client/mynewtemplate.js?

[Bejan]

@pitaj said in template.js not executed:

What are the contents of that file?

"use strict";
define("mynewtemplate",function(){
var t={};
t.init=function(){$("#last-p").text("mynewtemplate.js got loaded!");};
return t
});
//# sourceMappingURL=home.js.map

Have you tried just mynewtemplate.js instead of ../client/mynewtemplate.js?

You mean in the json file? I believe I tried that, too, once. Cannot remember the results. Will try again and report back.

[Bejan]

@pitaj What would happen if you're using the custom pages plugin to create a route mynewtemplate and put widgets inside at the same time as creating a file templates/mynewtemplate.tpl and a corresponding mynewtemplate.js file?

The custom pages template takes precedence it seems like. But even without the custom pages template, the mynewtemplate.js is not executed.

[baris]

Take a look at https://github.com/NodeBB/nodebb-plugin-quickstart/blob/master/static/lib/quickstart.js, that file is loaded when quickstart.tpl is rendered.

[Bejan]

@baris Thank you.

Well, that is where I got the JS from in the first place. I renamed the files from quickstart.* and added those to the custom theme, then adapted plugin.json. That is where I am at right now. I seem to cannot get the JS rendering to work. Template is shown, the last-p inner HTML is not. I'm out of clues now.

[baris]

@bejan said in template.js not executed:

define("mynewtemplate",function(){

This seems wrong, it should be forum/mynewtemplate like it is in quickstart plugin.

[Bejan]

@baris Your hint did it! Thank you!

Next question: where does that forum string come from? Is it because of some internal thing in nodebb?

Again, thank you!

[baris]

Yeah it is coming from https://github.com/NodeBB/NodeBB/blob/master/public/src/require-config.js#L8

[Bejan]

@baris Dam.. there it is, where all those magic strings meet!
Thank you.