[nodebb-plugin-cards] Show cards when hovering over user links!

[Schamper]

@baris userslugs with a - in them, right? Just looked at the regex and realised that \w doesn't include that character... Must've overlooked that.

So what are all the allowed characters in a userslug? Maybe it's best to make a overkill regex like \/user\/[^/]+$?

[julian]

Yeah, \w won't cover unicode either. You may as well use a blacklist instead of a whitelist.

[psychobunny]

This might be useful to you: https://github.com/NodeBB/NodeBB/blob/master/public/src/utils.js#L104-L105

You could just call this from utils, to save you the trouble

[Schamper]

I've changed the regex and pushed a new version.
https://github.com/Schamper/nodebb-plugin-cards/commit/46724b7e52502af585ce2f67bd9164b4e76560a6

@psychobunny I tried using [\[global:{status}]] in my template, but it didn't work... Just outputs as [\[global:online]]. Using the translator.translate now.
Just realised I could've also translated the other titles with this update... Oh well that's for the next one

Edit: funny... it translates it in my reply

Edit 2: I noticed there's no longer a .container anymore on this forum, guess I'll change that too.

Edit 3: Fixed edit 2 and figured the translator out 0.0.8 published.

[A Former User]

@Schamper

I've still got leftover cards hovering, most often when leaving a profile page. Both on the community site and my forum. Am I the only one?

[trevor]

@zenkamal Still a bit glitchy...

[Schamper]

Will look into it when I get the time.

[julian]

Are you using the latest version @zenkamal ?

[a_5mith]

It's started showing up on iPad for me, running latest as of last night some time, clicking on an avatar brings up the card, only a hard refresh removes it.

[A Former User]

@julian

Yup, waited until that was worked out to download.

[Schamper]

@zenkamal I'm unable to reproduce...

My "updated regex" had a flaw though, so I fixed that.

@a_5mith @psychobunny I added an event handler to remove a card when you click/tap outside of it. I've also published a new version. Let me know how it works.

tldr 0.0.9 published.

[Scuzz]

a tldr for 3 lines? damn people must be lazy.

[julian]

@Scuzz I'd tend to agree with you, but... I didn't read @Schamper's entire post *facepalm*

[psychobunny]

@Scuzz said:

a tldr for 3 lines? damn people must be lazy.

what's sad is I read this one first before the post above yours, because it had only one line

[trevor]

@Schamper said:

@zenkamal I'm unable to reproduce...

My "updated regex" had a flaw though, so I fixed that.

@a_5mith @psychobunny I added an event handler to remove a card when you click/tap outside of it. I've also published a new version. Let me know how it works.

tldr 0.0.9 published.

Well this works way better.

[Schamper]

@trevor so I assume I've made it less glitchy?

[trevor]

@Schamper Yeah for the most part.

[Schamper]

@trevor that's not very helpful What is still buggy etc?

[Schamper]

The very annoying bug should finally be fixed as discussed here: gh#1702

I've published 0.1.0 to npm, let me know how it goes!

(pinging @trevor ;))

[julian]

Thanks @Schamper ! Updated on this forum