[nodebb-plugin-cards] Show cards when hovering over user links!

[Schamper]

@julian but... how? That should prevent that from happening, right? It also should be impossible to happen in the split second between the AJAX call finishing and you navigating away because the currentCard variable is set after it has finished...

[baris]

Haha didn't I predict this? I think you need to make sure currentCard isn't changed before it is destroyed. It should always point to a single instance of card and it needs to be destroyed before another one is assigned to it.

[Schamper]

@baris @julian alright this should fix it in theory: https://github.com/Schamper/nodebb-plugin-cards/commit/007f3a65d3c9943d5623ca55056552e64b0f082a

I've published a new version because why not See if you can reproduce it now.

[trevor]

@Schamper said:

@baris @julian alright this should fix it in theory: https://github.com/Schamper/nodebb-plugin-cards/commit/007f3a65d3c9943d5623ca55056552e64b0f082a

I've published a new version because why not See if you can reproduce it now.

Great, you've destroyed my progress loader.

[Schamper]

@trevor I don't understand?

[psychobunny]

you sure it wasn't this commit instead?

[trevor]

@psychobunny thanks, how did I miss this?? WTF.

[julian]

Why do @Schamper's topics always generate so many replies ;_;

Such popularity, much wow.

[Schamper]

@julian hehe so far it only seems like this one, shoutbox and poll suggestions have been pretty popular. The actual plugin threads of the Poll and WebRTC plugin are pretty empty

[baris]

Realized if the userslug is nodebb-user they don't get a card, see the main post here https://community.nodebb.org/topic/1629/hackpad-plugin#12286.

[Schamper]

@baris userslugs with a - in them, right? Just looked at the regex and realised that \w doesn't include that character... Must've overlooked that.

So what are all the allowed characters in a userslug? Maybe it's best to make a overkill regex like \/user\/[^/]+$?

[julian]

Yeah, \w won't cover unicode either. You may as well use a blacklist instead of a whitelist.

[psychobunny]

This might be useful to you: https://github.com/NodeBB/NodeBB/blob/master/public/src/utils.js#L104-L105

You could just call this from utils, to save you the trouble

[Schamper]

I've changed the regex and pushed a new version.
https://github.com/Schamper/nodebb-plugin-cards/commit/46724b7e52502af585ce2f67bd9164b4e76560a6

@psychobunny I tried using [\[global:{status}]] in my template, but it didn't work... Just outputs as [\[global:online]]. Using the translator.translate now.
Just realised I could've also translated the other titles with this update... Oh well that's for the next one

Edit: funny... it translates it in my reply

Edit 2: I noticed there's no longer a .container anymore on this forum, guess I'll change that too.

Edit 3: Fixed edit 2 and figured the translator out 0.0.8 published.

[A Former User]

@Schamper

I've still got leftover cards hovering, most often when leaving a profile page. Both on the community site and my forum. Am I the only one?

[trevor]

@zenkamal Still a bit glitchy...

[Schamper]

Will look into it when I get the time.

[julian]

Are you using the latest version @zenkamal ?

[a_5mith]

It's started showing up on iPad for me, running latest as of last night some time, clicking on an avatar brings up the card, only a hard refresh removes it.

[A Former User]

@julian

Yup, waited until that was worked out to download.