[nodebb-plugin-cards] Show cards when hovering over user links!

trevor

Schamper

@trevor very nice! If see any improvements you can make to the default card, feel free to do so

I've renamed the plugin to nodebb-plugin-cards (who knows what it'll extend to, amirite?) and published the latest version with the latest fixes.
To upgrade you first have to remove the old plugin, and install the new one:

npm uninstall nodebb-plugin-mentions-cards
npm install nodebb-plugin-cards

Be sure to first disable it in the ACP!

For the people with custom cards, template has been changed to cards/profile.

julian

@Schamper Installed cards instead of mentions-cards, but now the CSS is gone Let me know

Schamper

@julian Right, I'm an idiot I've updated the styles.less in the repo but I can't push a new version until I get home tonight.

Schamper

@julian published new version, should be fixed now!

julian

Lookin' good @Schamper !!

julian

Eh... something got left over when I navigated away...

[Guide] Override the home page on a NodeBB | NodeBB - Google Chrome_007.png

Schamper

@julian but... how? That should prevent that from happening, right? It also should be impossible to happen in the split second between the AJAX call finishing and you navigating away because the currentCard variable is set after it has finished...

<baris>

Haha didn't I predict this? I think you need to make sure currentCard isn't changed before it is destroyed. It should always point to a single instance of card and it needs to be destroyed before another one is assigned to it.

Schamper

@baris @julian alright this should fix it in theory: https://github.com/Schamper/nodebb-plugin-cards/commit/007f3a65d3c9943d5623ca55056552e64b0f082a

I've published a new version because why not See if you can reproduce it now.

trevor

@Schamper said:

@baris @julian alright this should fix it in theory: https://github.com/Schamper/nodebb-plugin-cards/commit/007f3a65d3c9943d5623ca55056552e64b0f082a

I've published a new version because why not See if you can reproduce it now.

Great, you've destroyed my progress loader.

Schamper

@trevor I don't understand?

psychobunny

you sure it wasn't this commit instead?

trevor

@psychobunny thanks, how did I miss this?? WTF.

julian

Why do @Schamper's topics always generate so many replies ;_;

Such popularity, much wow.

Schamper

@julian hehe so far it only seems like this one, shoutbox and poll suggestions have been pretty popular. The actual plugin threads of the Poll and WebRTC plugin are pretty empty

<baris>

Realized if the userslug is nodebb-user they don't get a card, see the main post here https://community.nodebb.org/topic/1629/hackpad-plugin#12286.

Schamper

@baris userslugs with a - in them, right? Just looked at the regex and realised that \w doesn't include that character... Must've overlooked that.

So what are all the allowed characters in a userslug? Maybe it's best to make a overkill regex like \/user\/[^/]+$?

julian

Yeah, \w won't cover unicode either. You may as well use a blacklist instead of a whitelist.

psychobunny

This might be useful to you: https://github.com/NodeBB/NodeBB/blob/master/public/src/utils.js#L104-L105

You could just call this from utils, to save you the trouble