Links in Digest Emails are broken

dcook

Since upgrading to 1.16.2 my users have complaining that the links in the Digest emails are not working.

The email looks like this:

When you click on any of the "Read More" links it then says:

Can this please be fixed ASAP?

And can I please suggest that before releasing new version of NodeBB that it is more thoroughly tested by your developers?

PitaJ

@dcook what is the target url of the link?

dcook

@pitaj in the email if I right click on the "Read More" and select copy link address this is what it gives me:

https://u8551494.ct.sendgrid.net/ls/click?upn=02ZMW-2Fv-2BFEXPSGWKr-2FHrV8P3v8swfnbMEIahE8t-2Bpc8FNs0zOoBgPD44TOJzSKnop8lv_1et8C1wZO4x-2FVDY0cB-2Bq42SAdjKSd3YUdAqDjSy9uo-2BZSOzzGuZvGYBHtrQrwh7ou0p6-2FbkaLJpnsLb-2FabeAJ-2BHSJHcAhSCytxJI-2BvVVi25f5VnQil-2F73UCyykpZuh2C2MmJBseopS8vdLc8soTYiml33ogW8YoFGWEb6w611Zhhe391ezCso5aSeV5qX6kYGxliK4Z9OUOhmuG-2BUe-2BAIBhdUG4SwqyEK8d5VFgf3d8-3D

When I click on the "Read More" link it does take me to the site, but displays the error message:

I am using the Sendgrid plugin, but these links worked prior to 1.16.2 so I don't think its a problem with Sendgrid.

<baris>

Thanks for reporting, I'll fix this for 1.17.0.

https://github.com/NodeBB/NodeBB/issues/9382

dcook

@baris do you have an ETA on being released?

<baris>

@dcook Hopefully next week, you can apply the fix if you want to the tpl file https://github.com/NodeBB/NodeBB/commit/35700d1634bee0caf12226625fb1eaa185780100

dcook

@baris I will have to wait, I am a Windows Administrator trying to manage this on an Ubuntu server so out of my depth.

dcook

@baris Its been 2 weeks since you said hopefully next week, I don't see any upgrade notification in the ACP, has the timeline changed?

dcook

@baris Just wondering about this issue?

You had said hopefully next week, and that was over 1 month ago?
Is there an ETA?

<baris>

@dcook, we are aiming for next wednesday.