Section name not being included in breadcrumb

[inna]

Hello,

My website is: pythonforum.ir and as it's in Persian language, to acknowledge my mean I think it's better to use translators (sorry, I hope this sentence is not offensive, but if it is please pardon me and inform me).

I have created some Sections like Python 3 and Python 2 which are my issues now. Both sections have their own Q/A and Tutorials forums in which users can create topic.
But the issue is about breadcrumb that does not include and indicate the Section name.
If you go to https://pythonforum.ir/category/5/پرسش-و-پاسخ and https://pythonforum.ir/category/8/پرسش-و-پاسخ , you see in the breadcrumb that both have 'Home / Q/A' and if a user creates a topic in Python 2 forum for example, I cannot understand by seeing breadcrumb.

Is that an issue? Can I solve in Admin settings? I did not find any options for this.

Thanks in advance

[inna]

Bumps

[inna]

another bump:)

[baris]

From what I can see if a category is marked as a section in the ACP then it won't be used in the breadcrumbs. https://github.com/NodeBB/NodeBB/blob/master/src/controllers/helpers.js#L160

https://github.com/NodeBB/NodeBB/issues/5717

psychobunny created this issue in NodeBB/NodeBB

closed Category Sections #5717

[inna]

@baris thanks for the hint and reply.
I changed that line to this:

if (!data.disabled && data.isSection) {

And now it is working fine.
Is that right? And would this cause a problem in the future?
BTW, should I manually modify this file whenever I update/upgrade NodeBB? Am I right?

[baris]

You should actually change it to

if (!data.disabled) {

So all categories are used in the breadcrumbs whether they are sections or not.

[inna]

@baris I did this first and when I restart nodebb, my forum does not work. When I revert it back, it works again.
Anything wrong I did?

[baris]

That could be due to a loop in your category hierarchy, that code is in a while loop and if a category is a parent and child of another category by mistake it will never exit that loop.

Make sure your category tree doesn't have any loops.

[inna]

@baris that was fine and nothing was wrong with hierarchy.
It seemed it took some time to affect the changes. Now it's as you wrote down, and my forum is working.
The issue is solved, thanks.