[nodebb-plugin-recent-cards] NodeBB v1.14.0

[baris]

Looks like there was another bug in core that needed fixing for the images to show. https://github.com/NodeBB/NodeBB/commit/fef04fcf6bb1a0109686badc57bfa6e3e7da77a2 We will release a patch release on wednesday.

[FrankM]

Your fix works for me. Thank you!

[AnOdeToBB]

How come it won't show the category images only colours?

I have uploaded images for my categories but only see the colours I have set?

@baris is this the same issue as above? - thanks

[AnOdeToBB]

@anodetobb

[AnOdeToBB]

apologies for being pushy, is there any reason why this is happening?

Thanks

[baris]

Plugin needs updating to use category images if available. Right now it only uses color/icon.

[AnOdeToBB]

@baris Thanks for getting back.

So this can be done?

[baris]

Yes it can be done

[AnOdeToBB]

@baris That's great, so it just needs updating by yourself?

[baris]

I don't have time but anyone can do it and send a PR.

[AnOdeToBB]

@baris Thanks

[AnOdeToBB]

@baris realistically how easy is this to do?

[baris]

It was fairly simple I added this in 2.0.8, https://github.com/NodeBB-Community/nodebb-plugin-recent-cards/commit/82830b904ab4feb2526a106743ab4b7380ea33e9

[phenomlab]

@baris there is a bug in the console when upgrading

SyntaxError: await is only valid in async functions and the top level bodies of modules
    at compileFunction (<anonymous>)
    at Object.compileFunction (node:vm:355:18)
    at wrapSafe (node:internal/modules/cjs/loader:1039:15)
    at Module._compile (node:internal/modules/cjs/loader:1073:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.Plugins.requireLibrary (/home/phenomlab/nodebb/src/plugins/index.js:81:39)

[baris]

Thanks for reporting, this is fixed in 2.0.19.

[PitaJ]

@phenomlab yeah this commit broke it https://github.com/NodeBB-Community/nodebb-plugin-recent-cards/commit/ff3722e475a716116b827085aeaccad2a0c303c1 because of a missing async on renderExternal @baris

[phenomlab]

@baris said in [nodebb-plugin-recent-cards] NodeBB v1.14.0:

Thanks for reporting, this is fixed in 2.0.19.

Pleasure. Works perfectly now.

Thanks

[AnOdeToBB]

@phenomlab @baris

This is the reason...

NOW

Image Credit: @phenomlab

Absolutely brilliant @baris, the difference is clear

PREVIOUSLY