ACP Missing translation after upgrade

[linuxlover]

Hi,

After upgrading from 1.13.1 to 1.13.3 by doing git pull (on the master branch),
now when I browse the ACP, nothing is translated, I see the translation key instead of strings and in the log there are those lines

Missing translation "admin/dashboard:running-version"
Missing translation "admin/dashboard:up-to-date"
Missing translation "admin/dashboard:keep-updated"
Missing translation "admin/dashboard:notices"
Missing translation "admin/dashboard:restart-not-required"
Missing translation "admin/dashboard:search-plugin-installed"
Missing translation "admin/settings/languages:language-settings"
Missing translation "admin/settings/languages:description"
Missing translation "admin/settings/languages:default-language"
Missing translation "admin/settings/languages:auto-detect"

My browser is configured in en-US, and the rest of the forum is displaying fine (in english US).

I have no clue how to fix this problem, may someone help?

[PitaJ]

Can you try rebuilding and restarting NodeBB?

./nodebb build && ./nodebb restart

[linuxlover]

I just did and same issue:

Also I noticed that if in /user/<my_user>/settings if I change the Language > Admin Page Language to en-GB instead of en-US, the ACP displays correctly translated in english.

[PitaJ]

Hmmm can you check build/public/language to see if there are files for en-US admin stuff like there are for en-GB admin stuff?

[linuxlover]

I notice a different file hierarchy between them:

en-GB/
├── admin
│   ├── dashboard.json
│   └── settings
│       ├── languages.json

en-US/
├── admin
│   ├── general
│   │   ├── dashboard.json
│   │   ├── languages.json

Here is the comparison of both admin folders

~/nodebb/build/public/language$ rsync -r --ignore-existing -i -n en-GB/admin/ en-US/admin
>f+++++++++ dashboard.json
>f+++++++++ settings/homepage.json
>f+++++++++ settings/languages.json
>f+++++++++ settings/navigation.json
>f+++++++++ settings/social.json
>f+++++++++ settings/sounds.json
~/nodebb/build/public/language$ rsync -r --ignore-existing -i -n en-US/admin/ en-GB/admin
cd+++++++++ general/
>f+++++++++ general/dashboard.json
>f+++++++++ general/homepage.json
>f+++++++++ general/languages.json
>f+++++++++ general/navigation.json
>f+++++++++ general/social.json
>f+++++++++ general/sounds.json

that explains why...

[julian]

@linuxlover @PitaJ thanks for letting me know about this, the issue should be resolved now on latest master

[linuxlover]

@julian I confirm the issue is resolved, many thanks for the quick support ️