I think i will use websockets, thanks for the advice. At moment i'm using callbacks only because can't do different.
Probably async/await will be available from the next version (I've read that too).
translation for "post quick reply"
-
Hello,
I checked transifex and customize plugin, but could not locate where this string is located. How can I add a Turkish translation for "post quick reply"?
Thanks.
-
Yes I found this issue as well. What I did in the past is:
cd nodebb- search
post quick reply - Then replace it with your language and rebuild
It works. But everytime I update nodebb it was modified and I feel tired...It is better for nodebb team to merge these translations.
-
Added here https://github.com/NodeBB/nodebb-theme-persona/commit/c43c2ddbdbb80c3b2c4a338536f6cad4c0e1c56f, send your translations to the persona theme as pull requests.
-
@baris thanks. I added tr translation and created a pull request.
-
@crazycells @baris I have no idea how to pull using git... Could you please translate
post quick replyto快速回复in Chinese? I am sure this is the best translation. -
Courtesy GitHub: Creating a Pull Request.
Some stuff that came up about Pull Requests in Chinese that may or may not be useful. I don't speak/read anything other than English.
If you need some help getting to grips with git, Pro Git is available free online.
Which is all admittedly a bit much for non developer types who may not be familiar with revision control systems. Even so, some Git basics are good to know, as Git has become pretty much the defacto standard RCS these days.
Have fun!
-
@sharonyue said in translation for "post quick reply":
@crazycells @baris I have no idea how to pull using git... Could you please translate
post quick replyto快速回复in Chinese? I am sure this is the best translation.I do not know how Chinese is shortened, I guess
zh-CN? Maybe others can confirm... For pull request, first click here:https://github.com/NodeBB/nodebb-theme-persona/tree/master/languages
then click "create new file" and for path after
/languages/write:.../languages/zh-CN/persona.jsonTo create the file, in "edit file section", copy paste this with chinese translations...
{ "mobile-menu-side": "Switch which side each mobile menu is on", "post-quick-reply": "Post quick reply" }on the right side, delete "Switch which side each mobile menu is on" and replace it with chinese translation, and then delete "Post quick reply" and replace it with chinese translation...
then click create pull request, rest will be taken care of by the team...
-
@gotwf @crazycells Thank you guys. I use @crazycells 's method since I can work on chrome, which is simple. I just created a pull request.. lets see how it works
-
.../nodebb/nodebb/node_modules/nodebb-theme-persona/languages/trThere is a persona.json file in the directory and the translations have been made. However, it is still displayed in EN on the site.
-
@kurulumu-net said in translation for "post quick reply":
.../nodebb/nodebb/node_modules/nodebb-theme-persona/languages/trThere is a persona.json file in the directory and the translations have been made. However, it is still displayed in EN on the site.
Which NodeBB version are you using?
-
That key was actually moved from persona to core: https://github.com/NodeBB/nodebb-theme-persona/commit/41d6b558951240110f8a0cf72fe0c93c8d65a71a
And it's translated in core as well: https://github.com/NodeBB/NodeBB/blob/e6a46ef6ce0d65756454a00c3abc89b6150c9cf0/public/language/tr/topic.json#L184
-
@PitaJ @kurulumu-Net Yes, all should be translated in the Turkish version...
I have made some recent changes in the past weeks, and since we have recently upgraded our forum, I will go over some of the translations again soon on transifex after seeing the context in the forum...
@kurulumu-Net please let me know if you see any incomplete or funky translation... it is usually hard to translate long sentences perfectly in the first trial since Turkish and English are just opposite of each other.
