Login redirect and logout dont work after upgrade ?
-
Hello,
i just moved my nodebb on a new server and upgraded to 1.11.2, also the latest material theme upgrade. sadly i realized that the redirect after login doesnt work anymore. Same at logout. i cant logout from my account. no error message in my console for this...
Any ideas`?
-
I don't think the material theme is updated to work with 1.11.2
-
ohh ok , how can i downgrade again?
got it...
-
Yes, I have the same issue I am also using the material theme, persona works fine I have tested it
-
Broken due to breaking changes in login/logout functionality.
-
Same issue with the Lavender theme
Any pointers to solve this issue very much appreciated, thanks!
-
@baris May I ask what this breaking changes are and how to fix them in our own themes?
-
@Geferon https://github.com/NodeBB/NodeBB/pull/6841
closed Do not require a full refresh on login/logout #6841
-
Let me know if you can't resolve that in your theme... otherwise if it works, I'm sure @pichalite would appreciate a PR to material
-
Could you guys please point me out what part I would need to change in material-theme by pichalite to refresh the menu after login/logout, I have changed the logout to POST route instead GET but not sure what part I should change for top menu refresh after logout for example.
-
@Ne-Ho I believe I have managed to fix it in my custom fork of the Material theme:
https://github.com/geferon/nodebb-theme-materialSo far it works well on my forum without the page not refreshing/etc
-
@julian Actually, I asked to try and fix the material theme
-
ty for he fix for navigation it works now
Now i face some other issues, for the chat part I am not sure if that's happening only by me or others have similar issues
After update the main navigation slide toggle seems to be buggy, I believe that's an css issue, on toogle it also moves the whole container content
issue with navigation toogle, you can see the arrow position next to website name
I believe the loading chats should not be there
And I have also a warning in my chrome console
[deprecated] Accessing benchpress (formerly known as templates.js) globally is deprecated. Use `require(["benchpress"], function (Benchpress) { ... })` instead get @ app.js:24
-
@Ne-Ho Okay, I do have the chat Issue, i'll try to fix it, but I don't have the navigation toggle issue? I mean, is the sidebar on the left not positioned correctly for you, or what exactly is the problem?
-
@Geferon yes it is wrong positioned, it should be on the left side (left: 0) but you can see on my image that it is moved for about 10px to the right, also the navigation "hamburger" or arrow on the image is not well positioned ("tw-switch input").
And if you could also check if you have the same issue with chat rooms, if you open the chat room (https://github.com/geferon/nodebb-theme-material/blob/master/templates/partials/chats/message-window.tpl#L2) in full view in browser it seems that the scrollbar is not working here https://github.com/geferon/nodebb-theme-material/blob/master/templates/partials/chats/message-window.tpl#L56
-
@Ne-Ho I'm on my way of fixing this issues, tho it's strange because I don't get the positioning of the sidebar as you do
-
@Geferon I am not sure if I can share a link to my website, but if you visit my site you can play with the menu and you will see it. If the link is a problem we can remove it later this should just give you an idea what my issue is.
i have this issue since I uploaded your version, previous I had not this issue so if you have changed the css that would be helpfull
-
-
@Geferon look at top left corner on the image what you have sent, the left arrow next to site name. It hapend on any browser, I will revert back the theme to compare it with yours. Thank you for solving the theme issues btw
-
@Ne-Ho Oh you mean the arrow? Then I have fixed that in a internal version I have which I will publish in a few minutes.
I thought the spacing issue was https://i.imgur.com/Mz7ifwj.png
Like, the sidebar having empty space on the left
