Pull request in my repo! Advise me

[Jenkler]

I got a pull request with no description. Is that patch needed and why?

https://github.com/Jenkler/nodebb-plugin-postlink/pull/1/files

@julian

[baris]

It should be const meta = require.main.require('./src/meta');

[Jenkler]

Ok. but why does it work with only ./meta ? What is the issue with using ./meta? Seams to find it anyway

[PitaJ]

The change the guy suggested will actually break your plugin I think. The change he made should have been ../meta instead of ./src/meta. This is because NodeBB internal changes were made resulting in moved modules. Right now it has a backwards compatibility later but eventually plugins should switch to using require.main.require which will work the same regardless.

With require.main.require you need to change it from ./database to ./src/database.

[Jenkler]

Ohh, crap. I missed the "require.main.require" part Then its better to to patch this

[PitaJ]

@Jenkler the actual PR does not have require.main.require so it will break your plugin.

[Jenkler]

@baris said in Pull request in my repo! Advise me :

const meta = require.main.require('./src/meta');

https://github.com/Jenkler/nodebb-plugin-postlink/commit/c2f87f76259b03e31161bea21d9ae06df0f78b4e

[Jenkler]

lol, does it look OK now?

[Jenkler]

@PitaJ said in Pull request in my repo! Advise me :

@Jenkler the actual PR does not have require.main.require so it will break your plugin.

Yeah, found out that when it was to late But now it should be okay Thanks!

[Jenkler]

I need to watch out for my trigger fingers