No .. it is a lifetime subscription... then you can have 7500 montly notifications by app you register there. Can't remember how much I paid but was around ~2.50 for android and ~2.50 for browser, I'll try to do it.. but i'm learning nodejs yet =]
Pull request in my repo! Advise me ;)
-
I got a pull request with no description. Is that patch needed and why?
https://github.com/Jenkler/nodebb-plugin-postlink/pull/1/files
closed Update plugin.js #1
-
It should be
const meta = require.main.require('./src/meta'); -
Ok. but why does it work with only ./meta ? What is the issue with using ./meta? Seams to find it anyway
-
The change the guy suggested will actually break your plugin I think. The change he made should have been
../metainstead of./src/meta. This is because NodeBB internal changes were made resulting in moved modules. Right now it has a backwards compatibility later but eventually plugins should switch to usingrequire.main.requirewhich will work the same regardless.With
require.main.requireyou need to change it from./databaseto./src/database. -
Ohh, crap. I missed the "require.main.require" part
Then its better to to patch this -
@Jenkler the actual PR does not have require.main.require so it will break your plugin.
-
@baris said in Pull request in my repo! Advise me
:const meta = require.main.require('./src/meta');
https://github.com/Jenkler/nodebb-plugin-postlink/commit/c2f87f76259b03e31161bea21d9ae06df0f78b4e
-
lol, does it look OK now?
-
@PitaJ said in Pull request in my repo! Advise me
:@Jenkler the actual PR does not have require.main.require so it will break your plugin.
Yeah, found out that when it was to late
But now it should be okay Thanks! -
I need to watch out for my trigger fingers
