[nodebb-plugin-shortcuts] Browse NodeBB by Keyboard

julian

@frissdiegurke Good point, I didn't refresh to ensure that it happened 100% of the time... now that I try again, I can't reproduce it

Edit: Actually, I can, once the page has loaded via infinite scroll at least once... then hitting "r" while search dialog is open seems to close the search dialog and go to top of page...?

frissdiegurke

@julian Are you testing with chrome(/chromium) too or does it happen in fx there?
Maybe it's a bug of chrome itself and/or sth. within infinite-scrolling code

julian

Hey, now I'm noticing that it happens more often on the letter X...

You don't need to trigger infinite scroll, just open the find dialog, and toggle between x and bksp, and it'll trigger eventually.

frissdiegurke

I guess it triggers when the next match isn't visible so it has to scroll. it does scroll to the match when closing the search

frissdiegurke

@julian maybe it's because of the url-change on scrolling if a state gets pushed (new post visible). So chrome closes the search on pushstate... would need some more specific tests I don't want to do now

julian

@frissdiegurke Good catch! You're right, when I have the search dialog open and scroll up/down, it goes away once the url changes... hmmm

frissdiegurke

@julian that problem seems to be fixed now just for interest, have you changed anything or have the google guys fixed it?

Anyways: I've updated to provide a shortcut for the new groups-page and selection-functionality within.

I'd love to see this plugin back in use on this community (since the main target of all my plugins is this community xD ) - the 0.6.x issues have been fixed shortly after 0.6.0 arrival months ago

frissdiegurke

Updated (completely reworked, plain JS now) to NodeBB 0.9.0 and current lavender and persona themes.

Also transferred to https://github.com/NodeBB-Community/nodebb-plugin-shortcuts

frissdiegurke

Great news folks,
@julian has installed (once again) this plugin on this board

Just press ? to see how to get started...

Some notes for myself:

Implement Konami Code
Force input-selection after chat selection was triggered
Fix cards on categories page selection actions to refer to topic instead of category (might be best to fix within theme? component="categories/category" is misleading there @psychobunny )

EDIT: removed some notes for myself that got their individual issues within github.

julian

Oh, a Konami code, eh? One wonders what it will do...

Robert

Shouldn't Alt+Shift+A (Admin menu) be hidden for users who aren't admins?

frissdiegurke

@Kowlin indeed, it should.
EDIT: fixed.

phl

This plugin has compatibility issues with Macintosh keyboards.
Normally, "Alt+L" creates the @ character (which we need for pinging users @frissdiegurke), however due to this plugin "Alt+L" inserts a list into the posting, which is nice but definitely not what I want right now (desperately copy-pasting @ from outside nodeBB sucks).

frissdiegurke

@phl Already fixed a month ago https://github.com/NodeBB-Community/nodebb-plugin-shortcuts/issues/6

@administrators please reset to default bindings or update that particular one by hand. Thanks!

julian

@frissdiegurke updated. What about the up key in chat modal?