[nodebb-plugin-shortcuts] Browse NodeBB by Keyboard

frissdiegurke

@frissdiegurke Installed here, and wow, this is nice. First thing I tried was hjkl, so I'm glad those are implemented

One bug -- when I hit ? to bring up the help, I can't use the keyboard to scroll it

Otherwise really nice! Especially as I am on my laptop right now, and have no mouse

Fixed. Maybe it was not the best idea to add an own scroll-area to the bootbox ^^

frissdiegurke

Actions are now customizable
EDIT: shortcuts, not actions
Will do some changes on the Settings-framework I've done and then I'll send you a pull-request to add into core

psychobunny

Customizable actions? Congratulations you've won plugin weekend rofl

frissdiegurke

@psychobunny XD, I've coded for to long, I ment shortcuts ^^

psychobunny

haha yeah I figured

Retiring this and linking it to your repo
https://github.com/psychobunny/nodebb-plugin-mousetrap

frissdiegurke

@frissdiegurke said:

Fixed. Maybe it was not the best idea to add an own scroll-area to the bootbox ^^

Ah, I remember why I did that:
within Vanilla theme there is no scrolling otherwise, it gets cut off by screen height @psychobunny could you fix that please?

psychobunny

Sorry @frissdiegurke what do you mean?

frissdiegurke

@psychobunny I mean these annoying lines

julian

Holy hell, so that's why modals don't scroll on NodeBB, but they do on SaaS...

psychobunny

Haha weird, I wonder why that was even there in the first place. Removed it

BTW I think you won plugin weekend

julian

Haha did he? Submission+Voting technically goes until next Monday (though it's ended for you, @baris, and I)... though I think you and I are tied for 3

psychobunny

(haha but there's only one eligible entrant)

julian

What! You mean I can't actually win?

(╯°□°）╯︵ ┻━┻

julian

@frissdiegurke Hmm...

TypeError: Cannot call method 'apply' of undefined
    at /var/www/community.nodebb.org/node_modules/nodebb-plugin-shortcuts/services/Configuration.js:1:2764
    at /var/www/community.nodebb.org/src/meta.js:79:6

On plugin activation. Reported upstream: frissdiegurke/nodebb-plugin-shortcuts#1

frissdiegurke

Should be fixed now...

julian

@frissdiegurke I believe the latest version does not contain the settings module code that was merged this morning. By EOD if no other bugs crop up, I'll update the v0.4.x branch and 0.4.2 tag to include it.

frissdiegurke

@julian said:

I believe the latest version does not contain the settings module code that was merged this morning

correct

frissdiegurke

bump. @julian didn't you want to re-activate this plugin here? still waiting for it Or did another bug appear?

julian

@frissdiegurke Mmm, noticed just now that this plugin interferes with page searching. I tried searching "HAR" and the page reloaded

Any chance it can detect when the "find in page" dialog is open?

frissdiegurke

@julian Are you able to reproduce this step by step? It happens to me only sometimes (sth. like only at topics where I selected a post that forces infinite scroll to trigger and there only after pressing 'r' first). When it happens it seems like the 'a' (or 'A') closes the search-box somehow, because of this the 'r'/'R' gets interpreted by my plugin.
Basically I'm just using 'keydown' events (via jquery call), if I log there doesn't happen anything while focus is on browser-side search box.

So I have no clue why the 'a' closes this search-box sometimes (seems to be chromium only, fx doesn't close it in any test-case)...