[nodebb-plugin-shortcuts] Browse NodeBB by Keyboard

[frissdiegurke]

@psychobunny Dammit, and I got confused for quite a bit of time why the address bar gets focused every time I discard ^^ Will have to add some preventDefaults...
To answer your question: it'll be so when I'm done with the prevents

[psychobunny]

haha alright, looking forward to trying it out

[frissdiegurke]

Updated to 0.0.2-3: if anything is done by the actions the default-events get prevented now.
EDIT: Updated to 0.0.2-7: Added configuration (only selection-color configurable currently :P)

[julian]

@psychobunny said:

One thing I hate as an FF user is alt-d being re-routed... because I have a habit of using that to focus the address bar (instead of ctrl-L - don't ask me why).

God damnit @psychobunny, everyone knows legit programmers use F6 to access the address bar

[julian]

@frissdiegurke Installed here, and wow, this is nice. First thing I tried was hjkl, so I'm glad those are implemented

One bug -- when I hit ? to bring up the help, I can't use the keyboard to scroll it

Otherwise really nice! Especially as I am on my laptop right now, and have no mouse

[frissdiegurke]

@julian said:

@frissdiegurke Installed here, and wow, this is nice. First thing I tried was hjkl, so I'm glad those are implemented

One bug -- when I hit ? to bring up the help, I can't use the keyboard to scroll it

Otherwise really nice! Especially as I am on my laptop right now, and have no mouse

Fixed. Maybe it was not the best idea to add an own scroll-area to the bootbox ^^

[frissdiegurke]

Actions are now customizable
EDIT: shortcuts, not actions
Will do some changes on the Settings-framework I've done and then I'll send you a pull-request to add into core

[psychobunny]

Customizable actions? Congratulations you've won plugin weekend rofl

[frissdiegurke]

@psychobunny XD, I've coded for to long, I ment shortcuts ^^

[psychobunny]

haha yeah I figured

Retiring this and linking it to your repo
https://github.com/psychobunny/nodebb-plugin-mousetrap

[frissdiegurke]

@frissdiegurke said:

Fixed. Maybe it was not the best idea to add an own scroll-area to the bootbox ^^

Ah, I remember why I did that:
within Vanilla theme there is no scrolling otherwise, it gets cut off by screen height @psychobunny could you fix that please?

[psychobunny]

Sorry @frissdiegurke what do you mean?

[frissdiegurke]

@psychobunny I mean these annoying lines

[julian]

Holy hell, so that's why modals don't scroll on NodeBB, but they do on SaaS...

[psychobunny]

Haha weird, I wonder why that was even there in the first place. Removed it

BTW I think you won plugin weekend

[julian]

Haha did he? Submission+Voting technically goes until next Monday (though it's ended for you, @baris, and I)... though I think you and I are tied for 3

[psychobunny]

(haha but there's only one eligible entrant)

[julian]

What! You mean I can't actually win?

(╯°□°）╯︵ ┻━┻

[julian]

@frissdiegurke Hmm...

TypeError: Cannot call method 'apply' of undefined
    at /var/www/community.nodebb.org/node_modules/nodebb-plugin-shortcuts/services/Configuration.js:1:2764
    at /var/www/community.nodebb.org/src/meta.js:79:6

On plugin activation. Reported upstream: frissdiegurke/nodebb-plugin-shortcuts#1

[frissdiegurke]

Should be fixed now...