[nodebb-plugin-shortcuts] Browse NodeBB by Keyboard

frissdiegurke

Fixed. Maybe it was not the best idea to add an own scroll-area to the bootbox ^^

Ah, I remember why I did that:
within Vanilla theme there is no scrolling otherwise, it gets cut off by screen height @psychobunny could you fix that please?

psychobunny

Sorry @frissdiegurke what do you mean?

frissdiegurke

@psychobunny I mean these annoying lines

julian

Holy hell, so that's why modals don't scroll on NodeBB, but they do on SaaS...

psychobunny

Haha weird, I wonder why that was even there in the first place. Removed it

BTW I think you won plugin weekend

julian

Haha did he? Submission+Voting technically goes until next Monday (though it's ended for you, @baris, and I)... though I think you and I are tied for 3

psychobunny

(haha but there's only one eligible entrant)

julian

What! You mean I can't actually win?

(╯°□°）╯︵ ┻━┻

julian

@frissdiegurke Hmm...

TypeError: Cannot call method 'apply' of undefined
    at /var/www/community.nodebb.org/node_modules/nodebb-plugin-shortcuts/services/Configuration.js:1:2764
    at /var/www/community.nodebb.org/src/meta.js:79:6

On plugin activation. Reported upstream: frissdiegurke/nodebb-plugin-shortcuts#1

frissdiegurke

Should be fixed now...

julian

@frissdiegurke I believe the latest version does not contain the settings module code that was merged this morning. By EOD if no other bugs crop up, I'll update the v0.4.x branch and 0.4.2 tag to include it.

frissdiegurke

@julian said:

I believe the latest version does not contain the settings module code that was merged this morning

correct

frissdiegurke

bump. @julian didn't you want to re-activate this plugin here? still waiting for it Or did another bug appear?

julian

@frissdiegurke Mmm, noticed just now that this plugin interferes with page searching. I tried searching "HAR" and the page reloaded

Any chance it can detect when the "find in page" dialog is open?

frissdiegurke

@julian Are you able to reproduce this step by step? It happens to me only sometimes (sth. like only at topics where I selected a post that forces infinite scroll to trigger and there only after pressing 'r' first). When it happens it seems like the 'a' (or 'A') closes the search-box somehow, because of this the 'r'/'R' gets interpreted by my plugin.
Basically I'm just using 'keydown' events (via jquery call), if I log there doesn't happen anything while focus is on browser-side search box.

So I have no clue why the 'a' closes this search-box sometimes (seems to be chromium only, fx doesn't close it in any test-case)...

julian

@frissdiegurke Good point, I didn't refresh to ensure that it happened 100% of the time... now that I try again, I can't reproduce it

Edit: Actually, I can, once the page has loaded via infinite scroll at least once... then hitting "r" while search dialog is open seems to close the search dialog and go to top of page...?

frissdiegurke

@julian Are you testing with chrome(/chromium) too or does it happen in fx there?
Maybe it's a bug of chrome itself and/or sth. within infinite-scrolling code

julian

Hey, now I'm noticing that it happens more often on the letter X...

You don't need to trigger infinite scroll, just open the find dialog, and toggle between x and bksp, and it'll trigger eventually.

frissdiegurke

I guess it triggers when the next match isn't visible so it has to scroll. it does scroll to the match when closing the search

frissdiegurke

@julian maybe it's because of the url-change on scrolling if a state gets pushed (new post visible). So chrome closes the search on pushstate... would need some more specific tests I don't want to do now