Issue with Admin Panel since upgrade to 1.4.2

[teh_g]

@PitaJ said in Issue with Admin Panel since upgrade to 1.4.2:

@teh_g yeah I just pulled the latest from branch v1.x.x and I can't repro.

Hmm, could it be tied to something on the OS? Maybe something with the DigitalOcean box I am running?

[PitaJ]

@teh_g I'd suggest trying ./nodebb build

edit: I just tried it on linux as well. Worked fine.

[priapo]

@teh_g are you running it on a linux container (lxc)? Can I ask, are you using apache or nginx as proxy?

[priapo]

@PitaJ can I ask you something, ./nodebb build uses to close after finishing? here is showing

29/12 22:57:21 [490] - info: [build] Building javascript
29/12 22:57:21 [490] - info: [build] Building client-side CSS
29/12 22:57:44 [490] - info: [build] js => Completed in 22.595s

but it doesn't finishes, for minutes.

[PitaJ]

@priapo yeah the build script should close after finishing. It looks like you may have some corruption. Have you tried git reset --hard origin/v1.x.x?

[teh_g]

@priapo said in Issue with Admin Panel since upgrade to 1.4.2:

@teh_g are you running it on a linux container (lxc)? Can I ask, are you using apache or nginx as proxy?

nginx

Running it on an Ubuntu server from DigitalOcean.

[priapo]

I tried installing it in the host instead of inside a cointainer, and the error continues the same

It returns a 404 error when acessing

https://thewizards.club/api/language/en-GB/admin%2Fadmin

But finds it when acessing

https://thewizards.club/api/language/en-GB/admin/admin

@PitaJ can you tell us what you did to install it? I followed the rules in the docs for the Ubuntu.

EDIT: also this

[PitaJ]

@priapo have you tried accessing without a reverse proxy?

[priapo]

@PitaJ connecting direct it works..

[lonestar]

I have the same issue as @TaLoche with 1.4.2 after upgrading from 1.4.1.

[PitaJ]

@priapo so it must be something related to the reverse proxy. Maybe it's an issue caused by some weird issue between the reverse proxy and NodeBB

[priapo]

It was solved; here is my working Apache's nodebb.conf:

<VirtualHost *:80>

        ServerName thewizards.club
        Redirect permanent / https://thewizards.club

</VirtualHost>

<VirtualHost *:443>

        ServerName thewizards.club

        SSLEngine on
        SSLProtocol all -SSLv2
        SSLCipherSuite ALL:!ADH:!EXPORT:!SSLv2:RC4+RSA:+HIGH:+MEDIUM

        SSLCertificateFile /etc/apache2/ssl/thewizards-club/2_thewizards.club.crt
        SSLCertificateKeyFile /etc/apache2/ssl/server.key.insecure
        SSLCertificateChainFile /etc/apache2/ssl/thewizards-club/1_root_bundle.crt

#       ServerAdmin [email protected]


        <Proxy *>
                Require all granted
        </Proxy>

        ProxyRequests off
        #ProxyVia on
        AllowEncodedSlashes On


        #ProxyPreserveHost on
        RequestHeader set X-Forwarded-Proto "https"

        RewriteEngine On
        RewriteCond %{REQUEST_URI}  ^/socket.io            [NC]
        RewriteCond %{QUERY_STRING} transport=websocket    [NC]
        RewriteRule /(.*)           ws://127.0.0.1:4567/$1 [P,NE,L]
        # NE flag == noescape

        ProxyPass        /socket.io http://127.0.0.1:4567/socket.io nocanon retry=0
        ProxyPassReverse /socket.io http://127.0.0.1:4567/socket.io

        ProxyPass / http://127.0.0.1:4567/ nocanon retry=0
        ProxyPassReverse / http://127.0.0.1:4567/

        ErrorLog /home/web/logs/apache/forum-error.log
        CustomLog /home/web/logs/apache/forum-access.log combined

</VirtualHost>

I fixed it based on these resources:

Apache ProxyPassReverse escaping special characters

I have this very simple reverse proxy rule in Apache 2.2.19: ProxyPass /test http://other.local.machine/test ProxyPassReverse /test http://other.local.machine/test The problem is...

Server Fault (serverfault.com)

http://serverfault.com/questions/455060/cant-get-mod-proxy-to-correctly-forward-encoded-slash-characters-2f

[teh_g]

@priapo I wonder if there is something similar with nginx causing that?

[PitaJ]

@teh_g yes it appears that Nginx does the same thing. I could fix this by double encoding on both ends of NodeBB or something.

[priapo]

@teh_g I think if you google something like nginx proxy escaping you can find solutions on stackexchange/stackoverflow so you can update your nginx config..

[teh_g]

@PitaJ said in Issue with Admin Panel since upgrade to 1.4.2:

@teh_g yes it appears that Nginx does the same thing. I could fix this by double encoding on both ends of NodeBB or something.

I found the fix, it was shockingly easy!

The user guide suggests using the following config for nginx:

location / {
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header Host $http_host;
    proxy_set_header X-NginX-Proxy true;

    proxy_pass http://127.0.0.1:4567/;
    proxy_redirect off;

    # Socket.IO Support
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
}

I had to change the "proxy_pass" line to remove the trailing "/":

location / {
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header Host $http_host;
    proxy_set_header X-NginX-Proxy true;

    proxy_pass http://127.0.0.1:4567;
    proxy_redirect off;

    # Socket.IO Support
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
}

[priapo]

@teh_g Very good, that's why I always say, post your config files removing sensitive data. We would have helped you resolving this simple issue of removing the slash better.

[teh_g]

@priapo said in Issue with Admin Panel since upgrade to 1.4.2:

@teh_g Very good, that's why I always say, post your config files removing sensitive data. We would have helped you resolving this simple issue of removing the slash better.

I just grabbed that right from the documentation. It might be worth fixing the documentation.

[Jenkler]

I checked my config, no trailing slash on proxy_pass in my case. Thanks for the heads up! Its nice to learn something every day

[Michael Pfaff]

@teh_g I'm having the same admin dashboard issue. Would you mind walking me through what you did to check and fix this? Sorry, kind of a noob here.