3.8.0 Upgrade Support

bornelite

phenomlab

Hi. I upgraded my private forum (work) this morning to 3.8.1 and now receive the below error in the log plus repeated crashes where the process continues to restart

2024-05-21T11:31:21.669Z [4569/3989499] - error: TypeError: Class extends value undefined is not a constructor or null

Disabled all plugins, but the issue remains. Forced to recover from backup - all good now, but obviously keen to upgrade this outdated version (currently at 3.7.5)

<baris>

What version of nodejs? Haven't seen that error before

phenomlab

@baris currently at 3.7.5

<baris>

That's nodebb version, what is the version of nodejs, node -v?

phenomlab

@baris Sorry

v20.11.0

<baris>

That should be fine, is there no other messages after that line? Without a stacktrace can't tell where it is coming from.

phenomlab

@baris Sorry - see below

2024-05-21T14:02:52.051Z [4568/221902] - error: TypeError: Class extends value undefined is not a constructor or null
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.<anonymous> (/home/etp/domains/raptor.etp.local/nodebb/node_modules/@socket.io/redis-adapter/dist/sharded-adapter.js:27:55)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at require (node:internal/modules/helpers:176:18)
    at require (node:internal/modules/helpers:176:18)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at Object.<anonymous> (/home/etp/domains/raptor.etp.local/nodebb/node_modules/@socket.io/redis-adapter/dist/index.js:704:25)
    at Object.<anonymous> (/home/etp/domains/raptor.etp.local/nodebb/node_modules/@socket.io/redis-adapter/dist/index.js:704:25)
    at require (node:internal/modules/helpers:176:18)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.<anonymous> (/home/etp/domains/raptor.etp.local/nodebb/node_modules/@socket.io/redis-adapter/dist/index.js:704:25)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
[cluster] Child Process (221903) has exited (code: 0, signal: null)
[cluster] Child Process (221901) has exited (code: 0, signal: null)
[cluster] Child Process (221902) has exited (code: 0, signal: null)

<baris>

@phenomlab https://github.com/socketio/socket.io-redis-adapter/issues/539

Can you run npm ls socket.io-adapter in your nodebb folder and post the output?

$ npm ls socket.io-adapter
[email protected] D:\github\NodeBB
├─┬ @socket.io/[email protected]
│ └── [email protected]
└─┬ [email protected]
  └── [email protected] deduped

phenomlab

@baris

etp@etgawsapp01:~/domains/raptor.etp.local/nodebb$ npm ls socket.io-adapter
npm ERR! code ELSPROBLEMS
npm ERR! invalid: [email protected] /home/etp/domains/raptor.etp.local/nodebb/node_modules/socket.io-adapter
[email protected] /home/etp/domains/raptor.etp.local/nodebb
├─┬ @socket.io/[email protected]
│ └── [email protected] invalid: "^2.5.4" from node_modules/@socket.io/redis-adapter
└─┬ [email protected]
  └── [email protected] deduped invalid: "^2.5.4" from node_modules/@socket.io/redis-adapter


npm ERR! A complete log of this run can be found in: /home/etp/.npm/_logs/2024-05-21T14_11_36_480Z-debug-0.log
etp@etgawsapp01:~/domains/raptor.etp.local/nodebb$

phenomlab

@baris seems to be fixed with

npm install [email protected]

fgallese

@baris said in 3.8.0 Upgrade Support:

@bornelite do you have a stack trace from your nodebb log?

Im having the same error, my forum is down with this stacktrace:

nodebb  | 2024-05-23T14:36:47.794Z [4567/284] - info: 📡 NodeBB is now listening on: 0.0.0.0:4567
nodebb  | 2024-05-23T14:36:47.794Z [4567/284] - info: 🔗 Canonical URL: https://forobolso.uy/foro
nodebb  | WARNING: The keyword 'none' must be used as a single argument.
nodebb  |     ../../../bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
nodebb  |     ../../../bootstrap/scss/forms/_form-control.scss 40:7  @import
nodebb  |     bootstrap/scss/_forms.scss 3:9                         @import
nodebb  |     - 19:9                                                 root stylesheet
nodebb  | 
nodebb  | WARNING: The keyword 'none' must be used as a single argument.
nodebb  |     ../../../bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
nodebb  |     ../../../bootstrap/scss/forms/_form-select.scss 32:7  @import
nodebb  |     bootstrap/scss/_forms.scss 4:9                        @import
nodebb  |     - 19:9                                                root stylesheet
nodebb  | 
nodebb  | 2024-05-23T14:37:31.866Z [4567/284] - error: GET /foro
nodebb  | TypeError: categories.getCidByHandle is not a function
nodebb  |     at /usr/src/app/nodebb/node_modules/nodebb-plugin-mentions/library.js:402:32
nodebb  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
nodebb  |     at async Promise.all (index 0)
nodebb  |     at async Mentions.parseRaw (/usr/src/app/nodebb/node_modules/nodebb-plugin-mentions/library.js:398:2)
nodebb  |     at async Mentions.parsePost [as method] (/usr/src/app/nodebb/node_modules/nodebb-plugin-mentions/library.js:339:17)
nodebb  |     at async fireMethod (/usr/src/app/nodebb/src/plugins/hooks.js:256:11)
nodebb  |     at async Object.fireFilterHook [as filter] (/usr/src/app/nodebb/src/plugins/hooks.js:263:12)
nodebb  |     at async Hooks.fire (/usr/src/app/nodebb/src/plugins/hooks.js:192:17)
nodebb  |     at async Posts.parsePost (/usr/src/app/nodebb/src/posts/parse.js:63:16)
nodebb  |     at async Promise.all (index 0)

Any ideas ?

<baris>

@fgallese install nodebb 3.8.1 or install mentions plugin version 4.4.3.

fgallese

@baris said in 3.8.0 Upgrade Support:

@fgallese install nodebb 3.8.1 or install mentions plugin version 4.4.3.

Thank you will try

SinisterSpatula

Discovered an issue with the new docker setup that affects windows users. I could not get the nodebb container to startup it would always fail at "entrypoint.sh not found". It was caused by either git on windows adding dos line endings to the entrypoint.sh when cloning, or maybe because .sh is not in the repository .gitattributes file. I ended up getting it working with:

git clone -c core.autocrlf=false -b v3.x https://github.com/NodeBB/NodeBB.git

Which I think forces it to not mess up the line endings for entrypoint.sh when cloning the repo under windows.

Teemberland

hello, i'm stuck in an upgrade loop.

Upgrading from 3.7 to 3.8. When I run ./nodebb upgrade, I get the following error:

Error installing dependencies!
message: Command failed: npm install --omit=dev
stdout: null
stderr: null
/Users/new-user/some-folder/nodebb/src/cli/package-install.js:138
		throw e;
		^

Error: Command failed: npm install --omit=dev
    at checkExecSyncError (node:child_process:890:11)
    at Object.execSync (node:child_process:962:15)
    at pkgInstall.installAll (/Users/new-user/some-folder/nodebb/src/cli/package-install.js:129:9)
    at Object.<anonymous> (/Users/new-user/some-folder/nodebb/src/cli/index.js:52:18)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Module._load (node:internal/modules/cjs/loader:1013:12)
    at Module.require (node:internal/modules/cjs/loader:1225:19) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 36362,
  stdout: null,
  stderr: null
}

Node.js v18.19.1

phenomlab

@Teemberland can you run npm install before the upgrade?

Teemberland

@phenomlab ahh it's telling me that my custom theme isn't registered on npmjs.org. I've been using the custom theme (local machine), so I believe it is installed correctly. Is there a way to bypass this message?

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/nodebb-theme-custom-theme - Not found
npm ERR! 404 
npm ERR! 404  '[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

<baris>

Try adding your theme into package.json dependencies section and making sure it is in node_modules folder.

Teemberland

@baris hey thanks for replying!

the theme is in package.json and in node_modules. I did notice that it's not in package-lock.json.

I tried installing it using npm, but I received the same error. What else can I try?