NodeBB 3.6.0 minimum NodeJS version.

DownPW

Node JS v18.17.1 is good or not ?
How I can update to the latest stable versions of 18.x ? I do not remember.

blackd.t

What's the benefit off this though !

oplik0

@DownPW said in NodeBB 3.6.0 minimum NodeJS version.:

@baris

Node JS v18.17.1 is good or not ?

Yes, you just need a currently supported LTS version (and 18.17.1 is just a few months old) - generally NodeBB will move support along with node, and there shouldn't be any breaking changes within a major version, so all or most v18 versions should be supported at least until April 2025.

How I can update to the latest stable versions of 18.x ? I do not remember.

Depends on your OS and the way you originally installed NodeJS. Assuming you're on Ubuntu and followed NodeBB docs for NodeJS installation (that is, used nodesource):

for updating to a newer version from v18 branch, sudo apt update and sudo apt upgrade should suffice
for updating to v20, running the setup_current (instead of setup_lts) script should work:

curl -sL https://deb.nodesource.com/setup_current.x | sudo -E bash -
sudo apt upgrade

@blackd-t said in NodeBB 3.6.0 minimum NodeJS version.:

What's the benefit off this though !

The old request library is unmaintained and has a lot of issues. It is actually marked as deprecated on NPM. It's dead and it was clear for quite some time that it needed replacement. It even needed a separate package to add proper promise support, that's how old it was. It's less "it's better now" and more of just cleaning up technical debt.

The issue from my understanding is that there has been an obvious replacement for a long time - fetch API, which has been natively available in browsers for a while. So the question was "replace now with some other library then with fetch, or wait for fetch" (or keep using that library, risking same issue request experienced).
It seems NodeBB decided to wait, especially since with the faster EoL of Node 16 (faster due to to OpenSSL 1.1 EoL) it seemed right around the corner for some time.

Also, in general NodeBB follows NodeJS lifecycle, so officially only Node versions that are still supported are tested in NodeBB. Older versions can work, but there is no guarantee and generally I don't think NodeBB has any policy in place to wait with adopting newer features as long as they're in all supported Node versions.

<baris>

@oplik0 yep, I actually implemented axios first https://github.com/NodeBB/NodeBB/tree/axios. Which was easier but then decided to do this once and just went native fetch.

julian

Unrelated, but I think there were already issues with the Sharp dependency pushing us along as it required a certain version of node.js 18

Normando

@julian said in NodeBB 3.6.0 minimum NodeJS version.:

Unrelated, but I think there were already issues with the Sharp dependency pushing us along as it required a certain version of node.js 18

Yes, but not only with node.js 18, Sharp 0.33.x has issues with a lot of VMs. Please, revert to Sharp 0.32.6

https://github.com/lovell/sharp/issues/3870
https://github.com/lovell/sharp/issues/3900
https://github.com/lovell/sharp/issues/3911
and so on...

DownPW

We'll wait a little bit before upgrading

B-738

Agree! And confirm 3.6.1 with Sharp 0.33 on VM install in cloud kill all! Help npm install Sharp 0.32.6

I didn't know why!

B-738

@Normando said in NodeBB 3.6.0 minimum NodeJS version.:

Yes, but not only with node.js 18, Sharp 0.33.x has issues with a lot of VMs. Please, revert to Sharp 0.32.6

I do confirm ! Vultur Intel VM not work and received error with upload images!

Help --force install [email protected]

Please revert to that version!

<baris>

Will downgrade sharp to 0.32.6 and release a new patch version since we received other reports of the sharp error.