Layout shift in 1.17.1

klockprat

I see layout shift, a link to the first unread post usually ends up above the right target - I guess when images are being loaded.

This is seen in recent Chrome browsers on Android and IPhone.

Send a chat and I can share a url where this is visible (on hosted nodebb). We are new to nodebb and don't know if this is something that appeared in a recent version or not.

julian

Hi @klockprat -- NodeBB used to detect image shifts, but it was never very reliable.

Later versions of Firefox and Chrome now handle it natively, although I do not know if this extends to mobile versions.

NodeBB now no longer handles image viewport shifts.

klockprat

@julian I think I see this in Chrome on desktop as well, I will send you a link over chat to demonstrate. See if this gives you the right target as expected, or if it is too high up, thanks!

julian

@klockprat Thanks for sending the link -- it does go a little higher than expected, but the post is still within the viewport. This could be something we could try to account for with locally uploaded images, let me open a github issue:

https://github.com/julianlam/nodebb-plugin-markdown/issues/134

PitaJ

This is especially annoying on mobile with a short viewport.

julian

@pitaj Markdown plugin should automatically append width and height for images (both local and external) in the output HTML, which should help resolve these issues.

I think the real remaining cause of a viewport shift would be topic events. They're still rendered client-side right now.