[nodebb-plugin-adsense] Google Adsense

pichalite

@AOKP are you sure you are using the correct name? It's nodebb-plugin-adsense not nodebb-plugin-google-adsense

@lombisi the tpl file was missing from the module... added it to the repo... will be published to npm soon. Look for version 0.0.17

pichalite

@lombisi try 0.0.17

? Offline

@pichalite I will retry it tomorrow.
By the way, you maybe want to apply my hotfix for the main.js as well:
https://github.com/NodeBB-Community/nodebb-plugin-adsense/issues/1

lombisi

@pichalite all the ads were blank

AlexFung

@lombisi Is it the first time you create ads from google adsense?

lombisi

@AlexFung said:

Is it the first time you create ads from google adsense?

no. I made the necessary settings. But advertising space empty.

Why may be due?

lombisi

It worked.

I made mistakes:

Publisher ID: 123456789

Must be:

pub-123456789

How do we averaged ads?

? Offline

Improved main.js.

Whats working:

Ads are reload proof
Ads are displayed properly (mobile included)

Whats not working:

First post right and left ad are not displayed

lombisi

@AOKP I've tested. It did not work.

AlexFung

@lombisi My ads are all blank. I think it needs time for Google to review my website.

lombisi

@AlexFung said:

My ads are all blank. I think it needs time for Google to review my website.

If you apply a new.

but
if you are using before other sites: Publisher ID careful

Must be:

pub-123456789

? Offline

@lombisi this is related to the config file where the values are supposed to go. For some reason it does not saves it. Think this is next on the to do list.

AlexFung

@lombisi How long does it take for reviewing my site? Thanks!

lombisi

@AlexFung said:

How long does it take for reviewing my site? Thanks!

This is not at all certain. No specific time but not last very long.

faizanzahid

@dove great plugin, but we need not to show ads on adult content, please check the issue request.

https://github.com/dovydaskukalis/nodebb-plugin-google-adsense/issues/15

Cookie

I am still in the process of getting an AdSense account, one odd thing I noticed with plugin version 1.0.4 on Nodebb 1.12.2 is a weird rendering / navigation-to issue with the ACP. Whenever I exit the Google Adsense ACP and re-enter the ACP via navigation the ACP will not render. It will only render after one additional refresh or when I paste the ACP url from the navigation menu manually into the browser bar. It does seem to store settings fine.
I already reinstalled the plugin, re-ordered all plugins to the recommended order and did a rebuild a number of times, with no change. I hope this is just a harmless ACP navigation bug?

Cookie

This post is deleted!

<baris>

Updated this plugin with a new version(3.0.0), You can use the widget system in nodebb to place ads now instead of the hardcoded spots in the previous version. This is a breaking change for anyone using the plugin.

Joaquin Decima

For node 2.x or 3.x?

omega

@baris That’s rather cool! Thanks.