[nodebb-plugin-adsense] Google Adsense

UncleSam

Can I change AdSense to another ad service?

AlexFung

@lombisi I got the same problem for 0.0.16

lombisi

@AlexFung

? Offline

@lombisi I am working my own plugin with other ad locations.

lombisi

@AOKP So what's the problem?

? Offline

@lombisi basically it is the config file, where the AdminCP settings are supposed to go. It simply does not saves them for me.

lombisi

@AOKP "Plugins - Google Adsense" does not appear after clicking on something. I reinstall the page.

/admin/plugins/google-adsense
Failed to lookup view "admin/plugins/google-adsense" in views directory "/home/user/nodebb/public/templates"

? Offline

@lombisi for me the update to 0.0.14 is not even available. But I can confirm the same behaviour as I once uploaded all the new files to it. Maybe try to replace only the "main.js" for now.

pichalite

@AOKP are you sure you are using the correct name? It's nodebb-plugin-adsense not nodebb-plugin-google-adsense

@lombisi the tpl file was missing from the module... added it to the repo... will be published to npm soon. Look for version 0.0.17

pichalite

@lombisi try 0.0.17

? Offline

@pichalite I will retry it tomorrow.
By the way, you maybe want to apply my hotfix for the main.js as well:
https://github.com/NodeBB-Community/nodebb-plugin-adsense/issues/1

lombisi

@pichalite all the ads were blank

AlexFung

@lombisi Is it the first time you create ads from google adsense?

lombisi

@AlexFung said:

Is it the first time you create ads from google adsense?

no. I made the necessary settings. But advertising space empty.

Why may be due?

lombisi

It worked.

I made mistakes:

Publisher ID: 123456789

Must be:

pub-123456789

How do we averaged ads?

? Offline

Improved main.js.

Whats working:

Ads are reload proof
Ads are displayed properly (mobile included)

Whats not working:

First post right and left ad are not displayed

lombisi

@AOKP I've tested. It did not work.

AlexFung

@lombisi My ads are all blank. I think it needs time for Google to review my website.

lombisi

@AlexFung said:

My ads are all blank. I think it needs time for Google to review my website.

If you apply a new.

but
if you are using before other sites: Publisher ID careful

Must be:

pub-123456789

? Offline

@lombisi this is related to the config file where the values are supposed to go. For some reason it does not saves it. Think this is next on the to do list.