Group Chat Changes

a_5mith

I'm assuming each person only sees posts from after they're added to the room?

Perhaps @psychobunny needs to work some of his "-user- was added to the room" magic between posts.

Looking good @baris.

julian

Not even 12 hours after posting, @baris is getting feature creeped like mad Poor guy..

Robert

@julian I'm still waiting for the hidden features @psychobunny is releasing sooner or later,

JaredBusch

@Kowlin said:

@exodo any reason you want a option to disable it?

Maybe not a disable, but instead make a max participant value. If the forum admin sets it to 2, then it would be no different than now.

I really want the feature. I cannot count the number of times I have had a chat going and then had to either backfire things to another person, or take it to another medium (Skype/hangouts) in order to get a group chat going.

<baris>

@a_5mith said:

I'm assuming each person only sees posts from after they're added to the room?

Yes

exodo

@Kowlin said:

@exodo any reason you want a option to disable it?

Simple. I have seen many scenarios where group chats killed forum activity.

sanatisharif

@exodo Like our forum, group chat cause restarting nodebb forum ( 0.9.3 )!

pichalite

@sanatisharif group chat is not available in 0.9.3. Your issue might be something else and @exodo is talking about something else completely different.

sanatisharif

@pichalite

clone from master branch:

git fetch --all
git reset --hard origin/master
./nodebb upgrade

lock at these images please:

pichalite

@sanatisharif you are using master branch not 0.9.3. Master branch is expected to have issues and is not recommended for production.

pichalite

@julian master branch does not display the warning anymore in ACP?

sanatisharif

@pichalite how to downgrade our forum to nodebb 0.9.3 ?

pichalite

@sanatisharif did you make a backup before you upgraded? If not I believe you are out of luck and have to wait for a fix.

Nicolas

1.0.0?..
Don't forget, minor releases can't introduce breaking changes anymore.

<baris>

Group chat is only available on master not 0.9.3 as @pichalite mentioned. I just commited some fixes to master, you also need latest persona, let me know if you are still seeing issues after updating to those. For production wait for 1.0.0 if you want group chat.

sanatisharif

@baris @pichalite
Thanks a lot, Now every thing is fine!

sanatisharif

@baris said:

Group chat is only available on master not 0.9.3 as @pichalite mentioned. I just commited some fixes to master, you also need latest persona, let me know if you are still seeing issues after updating to those. For production wait for 1.0.0 if you want group chat.

restart again with this error:

21/12 15:07 [25414] - error: TypeError: Cannot read property 'messageId' of undefined
	at /path/to/nodebb/src/messaging.js:158:53
	at fn (/path/to/nodebb/node_modules/async/lib/async.js:741:34)
	at /path/to/nodebb/node_modules/async/lib/async.js:1208:16
	at /path/to/nodebb/node_modules/async/lib/async.js:166:37
	at /path/to/nodebb/node_modules/async/lib/async.js:701:43
	at /path/to/nodebb/node_modules/async/lib/async.js:167:37
	at Immediate._onImmediate (/path/to/nodebb/node_modules/async/lib/async.js:1201:34)
	at processImmediate [as _immediateCallback] (timers.js:367:17)
TypeError: Cannot read property 'messageId' of undefined
	at /path/to/nodebb/src/messaging.js:158:53
	at fn (/path/to/nodebb/node_modules/async/lib/async.js:741:34)
	at /path/to/nodebb/node_modules/async/lib/async.js:1208:16
	at /path/to/nodebb/node_modules/async/lib/async.js:166:37
	at /path/to/nodebb/node_modules/async/lib/async.js:701:43
	at /path/to/nodebb/node_modules/async/lib/async.js:167:37
	at Immediate._onImmediate (/path/to/nodebb/node_modules/async/lib/async.js:1201:34)
	at processImmediate [as _immediateCallback] (timers.js:367:17)
21/12 15:07 [25414] - info: [app] Shutdown (SIGTERM/SIGINT) Initialised.
21/12 15:07 [25414] - error: MongoError: server 127.0.0.1:27017 sockets closed
	at Server.destroy (/path/to/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:676:47)
	at Server.close (/path/to/nodebb/node_modules/mongodb/lib/server.js:367:17)
	at Db.close (/path/to/nodebb/node_modules/mongodb/lib/db.js:333:19)
	at Object.module.close (/path/to/nodebb/src/database/mongo.js:228:6)
	at shutdown (/path/to/nodebb/app.js:305:28)
	at process.<anonymous> (/path/to/nodebb/app.js:176:3)
	at process.emit (events.js:107:17)
	at process._fatalException (node.js:236:26)

<baris>

@sanatisharif What git hash are you on? git rev-parse HEAD

sanatisharif

@baris said:

git rev-parse HEAD

a6f484acf8afecb945721c749fc23ec8fbe28c64

<baris>

I can't find that hash in the nodebb repo