[nodebb-plugin-desktop-notifications] Desktop Notifications (like GMail)
-
info: NodeBB v0.2.0 Copyright (C) 2013 DesignCreatePlay Inc.
info: This program comes with ABSOLUTELY NO WARRANTY.
info: This is free software, and you are welcome to redistribute it under certain conditions.
info:
info: Initializing NodeBB v0.2.0, on port ---, using Redis store at 127.0.0.1:----.
info: NodeBB instance bound to: Any address (0.0.0.0)
info: NodeBB Ready/home/c/src/meta.js:218 mtime = +new Date(item.mtime); ^ TypeError: Cannot read property 'mtime' of undefined at /home/c/src/meta.js:218:32 at /home/c/node_modules/async/lib/async.js:246:13 at iterate (/home/c/node_modules/async/lib/async.js:131:13) at /home/c/node_modules/async/lib/async.js:142:25 at /home/c/node_modules/async/lib/async.js:248:17 at /home/c/src/meta.js:219:10 at /home/c/node_modules/async/lib/async.js:246:13 at iterate (/home/c/node_modules/async/lib/async.js:131:13) at /home/c/node_modules/async/lib/async.js:142:25 at /home/c/node_modules/async/lib/async.js:248:17
-
Am I missing something here?
-
Looks like @psychobunny used the wrong paths for the js scripts. For now you can run NodeBB in development mode with
./nodebb watch
or you can update to this https://github.com/designcreateplay/NodeBB/commit/c8e423e9cf86b74c15aa87d334f8dffc2c6e6074https://github.com/psychobunny/nodebb-plugin-desktop-notifications/blob/master/library.js#L8
Those paths are not existing and when NodeBB tries to minimize them it crashes.
Full list of scripts that went into the minify code
[ '/home/baris/node-forum/public/vendor/jquery/js/jquery.js', '/home/baris/node-forum/public/vendor/jquery/js/jquery-ui-1.10.3.custom.min.js', '/home/baris/node-forum/public/vendor/jquery/js/jquery.timeago.js', '/home/baris/node-forum/public/vendor/jquery/js/jquery.form.js', '/home/baris/node-forum/public/vendor/bootstrap/js/bootstrap.min.js', '/home/baris/node-forum/public/vendor/requirejs/require.js', '/home/baris/node-forum/public/vendor/bootbox/bootbox.min.js', '/home/baris/node-forum/public/vendor/tinycon/tinycon.js', '/home/baris/node-forum/public/src/app.js', '/home/baris/node-forum/public/src/templates.js', '/home/baris/node-forum/public/src/ajaxify.js', '/home/baris/node-forum/public/src/translator.js', '/home/baris/node-forum/public/src/utils.js', '/home/baris/node-forum/public/plugins/nodebb-plugin-desktop-notifications/vendor/notify/notify.js', '/home/baris/node-forum/public/plugins/nodebb-plugin-desktop-notifications/lib/main.js' ]
-
hey, good catch. there was an bug with minification that used the plugin's virtual static directory and not its physical directory in node_modules.
Updating to this commit will solve your issue
fix for minification of plugins static directories · NodeBB/NodeBB@5db27a8
Node.js based forum software built for the modern web - fix for minification of plugins static directories · NodeBB/NodeBB@5db27a8
GitHub (github.com)
-
-
do you know what notification specifically that was? in any case run
npm update
, I just added a catch to make sure that we don't show notifications that didn't have any text (for whatever reason) -
try
npm update
and lemme know if it works (version 0.0.6)push notifications in mobile works only on firefox mobile, haven't tested chrome mobile.
-
oh I get it. you need to update nodebb to this commit at minimum:
fix for minification of plugins static directories · NodeBB/NodeBB@5db27a8
Node.js based forum software built for the modern web - fix for minification of plugins static directories · NodeBB/NodeBB@5db27a8
GitHub (github.com)
here's what's blocking you:
also send notification data along with event:new_notification socket … · NodeBB/NodeBB@dc4aeca
Node.js based forum software built for the modern web - also send notification data along with event:new_notification socket … · NodeBB/NodeBB@dc4aeca
GitHub (github.com)
that's why data is undefined
-
np, I should have realized. you might have noticed its been activated on the community forum as well
-
i see.
-
@psychobunny I wanna ask something on mobile. Does it work with safari on iOS? also, i just tried on chrome does not seems to work.
-
var logo = $('.forum-logo').attr('src');
I don't want to use the forum logo, can I use a custom image for this?
-
maybe in the future I could add a way to upload a new picture. for now you could just take that line and replace it with any valid url ex.
var logo = 'http://domain.com/image.png';