[nodebb-plugin-adsense] Google Adsense

[finid]

@dove

@dove, do you have the time to apply the solution suggested by @bentael here to the plugin, that is,, the use of action:ajaxifying, action:ajaxified, and action:page.load, so that the ads will load on every user activity. Right now the ads show only on browser refresh.

[igbuend]

Small request: can you leave out the "http:" in the ad-sense URL in main.js? Now some browsers get a security warning when the forum is running with HTTPS. If you leave out the protocol, the browser will automatically user HTTP or HTTPS depending on what was used to load the page with the ad-sense link.

Thanks a lot!.

[quahfamili]

@dove Is this plugin still working in this version.

[gaasg]

The plugin seems to have some issues for me.

The ad for inside the post (I have it on the right side) is working perfectly fine from what I can see.

The bottom does not appear at all,

If I activate the ad in header breaks my forum and makes it inaccessible to everyone.

I have the latest version of nodebb.

[art]

hmm.. has anybody successfully run a site with Adsense?

I know Adsense doesn't really work with Discourse because of Ajax (the 3 ad rule gets triggered--search the Discourse forum). I guess it doesn't work with Nodebb either?

That would be a real bummer.

[art]

If nodebb can assemble the pages server-side so adsense will work, it would be a big advantage over Discourse.

https://news.ycombinator.com/item?id=7924916

Not being able to use adsense is a dealkiller for a lot of people.

[julian]

@art I believe our plugin works beyond 3 pages. @baris can confirm

[baris]

I don't think google adsense works with ajax, however I managed to get http://www.google.ca/doubleclick/publishers/small-business/ working in a widget for more than 3 page views.

I followed their guide and placed the code they give into the header of the page with the custom JS tab from ACP and then placed a widget that has this in it.

[psychobunny]

If you don't mind cold loading pages you can always disable ajaxify, that will serve a brand new page for every link and thus will be compatible with adsense.

EDIT: The other possibility would be to cache your adsense html and serve the same ad for every page, until the user comes back or refreshes manually

[Alex]

Is it not possible each time a page has got a new focus, it reloads only the ad block with a js event? I don't know if I am clear ^^

[jun]

Getting the error below for version 6.0

[drew]

@jun I have this too. I think this plugin is out of date now. Would be nice to see a v0.6.x compatible version.

[drew]

Can someone npm install this one and see if it now works for v0.6.x?
https://github.com/drewdotpro/nodebb-plugin-google-adsense

I don't have an AdSense account yet =(

[a_5mith]

@Drew-Llewellyn It's out of date, I'll create a PR for it later on. But it's down to the original dev to merge it.

[Tom Riddleff]

@Drew-Llewellyn I've got the following error:

ver. NodeBB v0.6.0.

[Huggy]

Hey,

Is there an update for this? Even a branch/fork? (new to git as well!) to get it working?

I been looking to try and work out how to fix but I'm still in learning mode.

Thanks

Dave

[pichalite]

@jun @Drew-Llewellyn @Tom-Riddleff @Dave-Huggy-Jones try the latest version. It should be compatible with NodeBB v0.6.x.

[Huggy]

@pichalite

Hey nice thanks, just done a install. it now showing in the CP

But looks like the relativePath is not being added to the url for the config file.
(I have installed on a /path)

Is this easy fix?

Thanks

Dave

[pichalite]

@Dave-Huggy-Jones which config file?

[Huggy]

@pichalite

I'm getting this error in the console log:

http://78.129.159.2/google-adsense.config.json 404 (Not Found)

My installation is on /forum whch evals ok when placed in the url directly like

http://78.129.159.2/forum/google-adsense.config.json

EDIT: Done a pull request for a fix on this.