[nodebb-plugin-shoutbox] Shoutbox plugin

Schamper

@ffmad that's actually already an open issue

Add timestamp · Issue #37 · NodeBB-Community/nodebb-plugin-shoutbox

GitHub (github.com)

I'm currently pretty busy with uni, but will hopefully have time soon to work on this again.

dylenbrivera

So pretty much, Shoutbox is like a global chatbox?

HolyPhoenix

@dylenbrivera

I think you add it as a widget. So anywhere the widget can display you can display it. I'm pretty sure it doesn't have to be global. Pretty much like a shoutbox on any other forum software, except its a lot easier to add where you want it.

Schamper

@dylenbrivera It's a shoutbox, what's more to say?

I'm working on this again, fixed some bugs, added some new features. Expect a new and better version sometime soon (I've only just started refactoring the client side, so not THAT soon ;))

Scriptdude

I can't figure out why the soutbox works on the homepage:

http://eredivisie.club/

But somehow it doesn't on a category page:

http://eredivisie.club/category/14/feyenoord

Schamper

@Scriptdude this was fixed very recently:
https://github.com/Schamper/nodebb-plugin-shoutbox/commit/9bfb4d986d22c744c8f338cd28e463ee83005e06

However, since I'm still working on refactoring everything, I haven't published a new version yet. If you're a daredevil you can clone the repo into the modules folder yourself

Eerste Nederlander die ik overigens tegenkom op NodeBB

Scriptdude

Hey

I tried cloning the repo, but that breaks it entirely. Must be some conflict with another plugin. I noticed that shoutbox conflicts with emoji on my installation (NodeBB 0.4.3)

I'll disable it for now and will wait for your next release Keep up the good work!

Mazzel!

Schamper

@Scriptdude Conflicts how exactly? We have the emoji plugin installed and it's working fine for us.

Ted

Hey @Schamper , could you publish on npm if that's ok for you?

I'd like to put it in my global sidebar.

And to add a little idea, the emoji are parsed but the dropdown doesn't appear when typing. I don't know if something can be done about that.

Thanks.

Schamper

@tedr56 That's because the emoji plugin doesn't currently allow me to add it's dropdown to any input

@frissdiegurke you could do something similar to what I did here for the mentions plugin to allow other plugins to add the dropdown to their inputs.

Continuing, I'll put some more work into this tonight, but I want to refactor some more before I publish to npm. For now you can clone the git repo.

frissdiegurke

@Schamper Great idea... implemented... see API.
addCompletion is the requested function.

Schamper

@frissdiegurke Awesome! This commit should be enough to support it, when will you release on npm?

frissdiegurke

@Schamper I publish with each commit, so everything on GH is also within NPM
To your code:
&& typeof emojiExtended.addCompletion !== 'undefined' is needless since it gets initialized with the function

Since I don't know in which order the scripts get called you may follow my suggestion to also listen on emoji-extended:initialized (window-object) therefore it's ensured that it works under all circumstances.

I've just created a PR for you: https://github.com/Schamper/nodebb-plugin-shoutbox/pull/48
But please test before publishing since I didn't

julian

Hey @Schamper, a little birdie told me that @BreakMetaNow has a community that's really dying to have multiple shoutboxes on NodeBB

Schamper

@julian a little Github issue already informed me The problem is that as of now, this would require a lot more work than what is actually worth it. I'm not saying I will never support this, but at least not anytime soon...

I might have an idea on how to approach this already, but no promises For example I want to support banning and muting users before I even consider this.

pwFoo

Tested the shoutbox plugin. Works fine, have some ideas to improve the plugin

User mention autocomplete and notification if user was mentioned in shoutbox?
Show a hint at shoutbox link if a new shout was made? Like at unread link / icon after new posts there.

Schamper

@pwFoo Auto complete has already been implemented in the latest version, it just hasn't been fully tested/prepared for 0.5.0 yet I thought about notifications for a bit but it would be too annoying, since mentions in a shoutbox would happen way more frequently than in a post.

About your second thing, do you mean in the tab/title bar? It should already do that (something like username has shouted), but I also noticed it's a bit of a hit and miss, though I can't really do anything about that, since I'm using a built in NodeBB function to do that. (I love you core devs ;))

pwFoo

Hi @Schamper
With my NodeBB test forum (0.5) there is no visual notification about mentioned in the shoutbox or a new shout... Tested with Chrome and Firefox. Also mention autocomplete seems not work.

Maybe you're right... notification about mentioned in shoutbox could be annoying.
But would be a great option to get a notification about it, because it's not a global shout. User was mentioned and maybe missing it.

If you don't want a notification (maybe also pushed by Pushbullet...) a counter about new shouts and/ or counter how often mentioned at shoutbox. Without attracting attention new shouts/ mentions could be missed.

a_5mith

Also noticed that embedding images doesn't set them to 100% width. Had to add max-width to the shout box. Could be worth setting in the plug in css

Tanner

So as I understand it, you can't have this function on anything but one page?