[nodebb-plugin-shoutbox] Shoutbox plugin
-
-
@frissdiegurke Awesome! This commit should be enough to support it, when will you release on npm?
-
@Schamper I publish with each commit, so everything on GH is also within NPM
To your code:
&& typeof emojiExtended.addCompletion !== 'undefined'is needless since it gets initialized with the functionSince I don't know in which order the scripts get called you may follow my suggestion to also listen on
emoji-extended:initialized(window-object) therefore it's ensured that it works under all circumstances.I've just created a PR for you: https://github.com/Schamper/nodebb-plugin-shoutbox/pull/48
But please test before publishing since I didn't -
@julian a little Github issue already informed me
The problem is that as of now, this would require a lot more work than what is actually worth it. I'm not saying I will never support this, but at least not anytime soon...I might have an idea on how to approach this already, but no promises
For example I want to support banning and muting users before I even consider this. -
Tested the shoutbox plugin. Works fine, have some ideas to improve the plugin
- User mention autocomplete and notification if user was mentioned in shoutbox?
- Show a hint at shoutbox link if a new shout was made? Like at unread link / icon after new posts there.
-
@pwFoo Auto complete has already been implemented in the latest version, it just hasn't been fully tested/prepared for 0.5.0 yet
I thought about notifications for a bit but it would be too annoying, since mentions in a shoutbox would happen way more frequently than in a post.About your second thing, do you mean in the tab/title bar? It should already do that (something like
username has shouted), but I also noticed it's a bit of a hit and miss, though I can't really do anything about that, since I'm using a built in NodeBB function to do that. (I love you core devs ;)) -
Hi @Schamper
With my NodeBB test forum (0.5) there is no visual notification about mentioned in the shoutbox or a new shout... Tested with Chrome and Firefox. Also mention autocomplete seems not work.Maybe you're right... notification about mentioned in shoutbox could be annoying.
But would be a great option to get a notification about it, because it's not a global shout. User was mentioned and maybe missing it.If you don't want a notification (maybe also pushed by Pushbullet...) a counter about new shouts and/ or counter how often mentioned at shoutbox. Without attracting attention new shouts/ mentions could be missed.
-
So as I understand it, you can't have this function on anything but one page?
-
I mean if I place it as a widget, say on the global footer, it'll only work on the homepage and not any other page, yes?
-
@Scuzz I'm quite aware of that. When I place it in the global footer, it does not function on any page but the homepage, as in it will only work on the homepage and not on any other page. I said that already but I don't think I can be more clear lol
-
@Tanner Can confirm the diagnosis above. Only works on the homepage. (Or possibly whichever page is cold loaded, try cold loading category, then going to homepage, then back to category again) Either way, after ajaxify, chat is empty. Send button doesn't work.
-
I had it on the Global header before and it work fine on every page.
Edit
@Tanner @a_5mith My bad, i didnt quite understand what you were asking. It seems that it wont work in other widget areas.I thought we had it working but that might be because we were using the latest github version and not the npm version.
Two seconds I'll check on mine,
