Nested quotes

PitaJ

4 deep

3 deep

2 deep

1 deep

0

To hide nested quotes 3 deep or more, you can use the following custom CSS:

blockquote > blockquote blockquote {
  display: none;
}

To hide 2 deep or more, use this:

blockquote blockquote {
  display: none;
}

Also, what happened to the quote collapsing? It works on this forum.

jarey

@PitaJ well in a product that is ment to be usefull and easy to use, i don't think yhe solution to something that the app let's you do, is "don't do it, you're retarded fucking user".

An not everybody is supposed to know how markdown works, it's the point for having a composer/editor or whatever you wanna call it.

It's like if you make 2 entries in your calendar plugin and suddenly it would look like shit. You can't simply tell the user 'don't register to events for the same date'. That's not well-built software (just an example of course).

PitaJ

@jarey well, I gave you a solution to hide them if you want. There is also already a built-in feature to hide deeply nested quotes with a little arrow button to show them.

jarey

@PitaJ I'm thankfull for the solution you gave us. Just wanted to write my oppinion on the 'it is user's fault'.
Thanks again.

exodo

@PitaJ said in Nested quotes:

@jarey well, I gave you a solution to hide them if you want. There is also already a built-in feature to hide deeply nested quotes with a little arrow button to show them.

Css solutions are nice but can be considered as a patch only.
You already used mention instead of quote on this topic and you said that people using long nestquotes are doint it wrong, then why have that option? Only for that people?

Also nodebb is not only webapplication, hiding with css will only work for website but you will still get full quotes with hundreds of > characters on pushbullet,telegram,rss,email etc

Just to be clear. I dont want nested quote to be removed but a good solution could be to have the option to enable/disable on admin panel or avoid to nest quotes till infinite, maybe 4-5 max.

Thanks for the replies

PitaJ

@exodo hour about this: we modify the "quote" feature (clicking quote beneath a post) and make it so it automatically removes the extra quotes before they are even added to the composer.

alberto__segura

@PitaJ said in Nested quotes:

4 deep

3 deep

2 deep

1 deep

0

To hide nested quotes 3 deep or more, you can use the following custom CSS:
blockquote > blockquote blockquote {
  display: none;
}
To hide 2 deep or more, use this:
blockquote blockquote {
  display: none;
}
Also, what happened to the quote collapsing? It works on this forum.

This workaround is shit. It is inefficient. It could reach a high data usage over 3G/4G. As you said, users dont need more than 3 levels of deep, so why not to remove it? We could do NodeBB easier, faster and more efficient.

PitaJ

@alberto__segura

Why not remove it?

Because it's an intrinsic part of markdown that requires work to remove.

exodo

@PitaJ said in Nested quotes:

@exodo hour about this: we modify the "quote" feature (clicking quote beneath a post) and make it so it automatically removes the extra quotes before they are even added to the composer.

sorry for my english but i didnt undertand this sentence, can you explain?

PitaJ

@exodo there's a quote feature. The "quote" link below the post automatically copies the text from the quoted post and inserts quotes in front. If, instead, we parse out those nested quotes when the text is copied, they will be removed before the post is even submitted.

For instance: if we have a post like this

The sky is blue

The grass is green

Then the "quote" reply post in the composer would be like this normally (before the reply was written):

> > The sky is blue
> 
> The grass is green

But instead the nested quotes are removed like so:

> The grass is green

exodo

@PitaJ said in Nested quotes:

@exodo there's a quote feature. The "quote" link below the post automatically copies the text from the quoted post and inserts quotes in front. If, instead, we parse out those nested quotes when the text is copied, they will be removed before the post is even submitted.

For instance: if we have a post like this

The sky is blue

The grass is green

Then the "quote" reply post in the composer would be like this normally (before the reply was written):
> > The sky is blue
> 
> The grass is green
But instead the nested quotes are removed like so:
> The grass is green

Seems ok as long as it works.
we had modified composer just for that time ago but i prefer suggest new additio s amd changes for community before modify core or core plugins.

remove quotes better · exo-do/nodebb-plugin-composer-exodo@da2351c

Contribute to exo-do/nodebb-plugin-composer-exodo development by creating an account on GitHub.

GitHub (github.com)

alberto__segura

@PitaJ said in Nested quotes:

@alberto__segura

Why not remove it?

Because it's an intrinsic part of markdown that requires work to remove.

we only need a simple regex, we did it in older versions with a custom composer (https://github.com/exo-do/nodebb-plugin-composer-exodo/commit/da2351cf94baf1c8580af4c760b1ff19785e3198), but we cannot maintain our own custom composer. It should be part of default NodeBB composer.