@pitaj That makes sense.
Thank you, I think that answers my question.
User Icons Testing
-
@exodo that sounds like an "of course" or "we'll keep it in core as an option" thing to me
-
@pitaj In general, we'll try to minimise core as much as possible, so gravatar will be a plugin. Whether or not we develop it, or a third-party developer, is still open.
When this is tested and merged, there won't be gravatar support for a little bit, until said plugin is created.
-
How will this work with plugins wanting to show a users' avatar?
-
Breaks the chat taskbar.
-
-
The icons seem to be predominantly red in colour. Is the colour randomly generated?
-
They are, yes. From a selection of 5 or 6 colours.
-
Custom colors ftw. You should add the uid as a classname for custom colors with custom CSS.
Something like user-icon-[uid]
-
@julian you could get the colours to be more varied than that. In my project I used an MD5 hash of the person's username to get a hex colour that's highly likely to be unique. For ex:
$hash = md5( $username ); $hex_colour = substr( $hash, 0, 6 );JavaScript obviously doesn't implement an
md5()function but you could maybe use a library? -
@henrywright hell, you could just generate six random hex characters and you'd do fine.
-
@pitaj you could, but that doesn't quite achieve uniqueness. MD5 isn't perfect but 99.99% of the time you'll get a unique colour from a username argument.
-
@henrywright yeah, there's a chance, but it's rediculously small. You are 99.99999% likely to get a unique color.
-
@pitaj true but calling something like MD5 on a username string will ensure you get the exact same colour for a particular user each time. That's something that's important if you're doing this each time on the fly and not storing the generated image.
-
-
@henrywright said:
The icons seem to be predominantly red in colour. Is the colour randomly generated?
That's definitely unintentional, just luck
The reason why we select from a set list is mostly because not all colours look good as icons (e.g. pity the user who gets
#ff0000background), and maybe half don't look good with white as the text colourThese are some fancy colours that I use... (the yellow one doesn't work so well as you can see, and I don't use the greys at all)
-
@julian Nice color selection.
-
@julian Thanks for explaining, that sounds reasonable to me!
Regarding the avatars on the users page https://community.nodebb.org/users
For me, it seems only some are loading. I see a lot of blank white space where an avatar should be. Also if I scroll down the page I see the mystery man instead of the new "letter" icon.
Is this just me? I'm currently using latest Chrome on Chrome OS.
-
Hm, that's not right... not sure why they're showing up blank, while two others were working okay.
Also there's a user named @ElonMusk LOL
-
@julian said:
Also there's a user named @ElonMusk LOL
Yup, noticed that too. Keep an eye on the Tesla website for a NodeBB-powered forum
-
Tooltip is not displayed on the teaser.
