[nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB

phenomlab

@BrotherGlaucon anything in the browser console or in the NodeBB log?

BrotherGlaucon

@phenomlab - Yes, I was just looking at that now.

There is a console Uncaught ReferenceError: require is not defined at <this line of reputation-rules.tpl>.

There was also a problem with the emoji plugin, but I deactivated that for the time being. I don't know if it was interconnected.

(v2.8.12)

TheBronx

Haven't touched this in a couple years and I am not using NodeBB anymore but I can give it a try, if it is something stupid I can probably fix it and release a new version. No promises, will just have a look.

<baris>

Since nbb 2.x we don't use requirejs so embedding javascript into templates like that isn't supported, it needs to be a module defined in plugin.json and a separate javascript file. Take a look at https://github.com/NodeBB/nodebb-plugin-quickstart/blob/master/static/lib/admin.js for a sample.

BrotherGlaucon

@TheBronx - Before you do anything, let me try to make sure my system is set up correctly. Now I am getting a console error error loading admin/plugins/reputation-rules. I am wondering if the plugin failed to install correctly (although reinstallation didn't seem to help).

phenomlab

@BrotherGlaucon try a rebuild

BrotherGlaucon

@phenomlab - Yes, I have tried rebuilding, reinstalling, removing other plugins, and switching to v2.x.

@baris - I do get an error related to <this thread>, but I am not able to locate the config.json file. Has this changed since 2018?

TheBronx

Looks like settings in ACP have changed since last release as @baris pointed out
Unfortunately the nodebb-plugin-quickstart that serves as example/documentation wasn't enough to have the ACP completely working. Settings are no longer empty when I reload that page, but if I navigate somewhere else and then go back to the plugin settings they are empty. No idea why.
I also found this: https://community.nodebb.org/topic/16958/how-do-i-create-a-settings-page-for-my-plugin
But it again points out to the quickstart plugin and that plugin throws errors, it doesn't work in NodeBB 3.1.6

So I could not fix this issue, which is pretty annoying considering how basic this is for a plugin. That's all the time I had, sorry.

<baris>

@TheBronx sent a PR, https://github.com/exo-do/nodebb-plugin-reputation-rules/pull/13. This updates the acp to work with upcoming 3.2 release. If you want to check it out you can use it against develop branch of NodeBB.

BrotherGlaucon

Thanks, @baris!

exodo

Merged the pull request. Didn’t check if working. If you want to take care of the plug-in you cam have it as we don’t have developers to continue with it

<baris>

@exodo you can transfer it to nodebb-community organization on github

phenomlab

@exodo @baris did this every get merged? Quite reliant on this plugin now and without the updates you can't save any of the settings.

Thanks both.

<baris>

@phenomlab published @nodebb/[email protected] it's compatible with nodebb 3.2.0, which is coming very

phenomlab

@baris thanks for this. Really appreciated. We'll wait for 3.2.0 to drop.