share NodeBB Header and Footer

bentael

@StuartH
I re-wrote most of this nodebb-plugin-42 today, I also added append to <head> config but keep in mind that this append occurs on document.ready, and made it compatible with NodeBB latest master.

give it a shot, let me know if it still sucks.

StuartH

@bentael said:

@StuartH
I re-wrote most of this nodebb-plugin-42 today, I also added append to <head> config but keep in mind that this append occurs on document.ready, and made it compatible with NodeBB latest master.

give it a shot, let me know if it still sucks.
Yea thanks Bentael I will give it a try?

StuartH

It briefly worked but now the "42" has disappeared from the side bar so I can not use it, did do a empty cache and restart but it wont come back

bentael

@StuartH lol that's weird, are on NodeBB edge?

julian

@bentael he is, yep.

bentael

I can't reproduce the problem. any error logs? on both server and client sides?

do you have a demo public link I can use to login and check?

are you on Mongo or Redis, (not that it should make a difference, but just the new code used another way to save configs)

StuartH

Well this is strange I just went back on to the admin page and there it is "42" is back are you guys messing with my head that or I need a lie down in a dark corner

finid

@StuartH

Knowing that the devs are a nice bunch, finding the nearest dark corner might not be such a bad idea. Just stay away from a connected device while you are there

StuartH

It gets better @planner I thought I would test it out by copy/past some html from my MOTD to the footer, nothing happened so did the same for some text again nothing so I deleted the code went back on to the front end and there it is (doh)

StuartH

Now I do not know how to get rid of the text as it's not need there, think I will leave it a while then through salt over shoulder and look again to see what i get this time

bentael

@StuartH it may have to do with how often NodeBB calls the filter:footer.build hook, and since it's a SINGLE PAGE APP, it's not much, I've seen that weirdness, but I am not too sure what to do about it, the filter is pretty straight forward. what you can do to verify that's the footer code is being generated correctly, is to view-source of the page, then search for nodebb-plugin-42 comment.
if for some reason, the javascript generated is invalid, you may have a page error. I am working on a fix for this issue