Do you not have npm installed? What version of node?
Youtube lite in 0.7.x
-
I am using the older plugin because the "lite plugin does not work". Unable to update to 4.x in admin acp. And the the display of tubes does not work att all
I am now running the "stable" 0.7.x branch, plz advice.
Link: https://www.nodebb.se
-
@Jenkler said:
I am using the older plugin because the "lite plugin does not work". Unable to update to 4.x in admin acp. And the the display of tubes does not work att all
I am now running the "stable" 0.7.x branch, plz advice.
Link: https://www.nodebb.se
@julian broke it.
Use 0.3.2. -
I will use the old plugin until lite is fixed! Plz update med if someone fixes it
-
@a_5mith hey, didn't we republish the reverted commits?
-
Nope. You said you'd do a PR for it. But don't think it's come through yet. Will double check when I get home.
-
Would be nice to have a working lite in 0.7.x
-
-
But why don't use the non lite version until 4.x is fixed?
-
@a_5mith I looked over your commits, it looks like you reverted the commits successfully
-
-
@a_5mith, @julian
Well, not completely though.You forgot to revert the hook-change in plugin.json:
https://github.com/rbeer/nodebb-plugin-youtube-lite/commit/ca010e57054a29632a1d400d6708f5bd20f53d31The "error throwing" part of the com-message refers to
https://github.com/rbeer/nodebb-plugin-youtube-lite/blob/master/static%2Flib%2FlazyYT.js#L21At that point I get
ratio === undefined, yet width is also not given. Whereever this$elcomes from there, it doesn't have.dataset.ratio, nor.dataset.widthanymore.
Can't explain why it's not showing in your ACP list. Didn't have any problems with that.
If it were working, would you prefer that Markdown hook over the post-parse one? Regarding downward compatibility, I'm hoping that there's a way to add hook handlers in an
initfunction, isn't there? So you could check for Markdown and from there on set the appropriate hooks.
