Split JS Minification on Client/Board and ACP

Nicolas

Hello guys,

Would be nice to have 2 different concatenated/minified scripts for board and ACP.
Now it's single nodebb.min.js.
I propose split responsibilities, so we will have nodebb.min.js and acp.min.js

@baris @julian @psychobunny what do you think on it?

<baris>

It's a good idea, it would also reduce the size of nodebb.min.js

psychobunny

I just looked it up, there is no ACP related code in nodebb.min.js, but it is also included on the ACP side for libs like ajaxify

Nicolas

@psychobunny Plugins will grow. And adding JS related only for UX in ACP, isn't great

psychobunny

oh I see, you're looking to improve the ACP's performance. yeah that makes sense. I think all ACP needs is app, ajaxify, translator, and templates.js

Nicolas

Give ability to specify in plugin.json, where my js should be concatenated
In my case, 95% of client JS is related to ACP, but It's part of nodebb.min.js...

psychobunny

Gotcha, I totally forgot about the fact that nodebb.min.js includes ACP plugin scripts as well. In that case I take my first comment back - even on this community it should cut down maybe 10-20kb worth

acp.min.js · Issue #3134 · NodeBB/NodeBB

Right now, ACP just requires all files separately and unminified. Additionally it includes the entire nodebb.min.js file despite the fact that it only requires app, ajaxify, translator, and templates.js Also, allow plugins to define acpS...

GitHub (github.com)

julian

Nicolas, I'm assuming you don't want to put your js inline in the template?

For my plugins (I have my own fork of quickstart that I use), I actually make them require.js modules, so they are loaded on-demand: https://github.com/NodeBB/nodebb-plugin-quickstart/blob/julian/static/lib/admin.js

But looking back, this might also minified, so...