boi
[nodebb-plugin-ns-awards] NS Awards, Give Medals!
-
Well since it seems that you don't have enough time to update it, I tried to achieve the automatic reward system.
But since I'm new with those kind of stuff (javascript, nodejs, nodeBB, mongoDB, et cetera) I don't know if what I did is correct, because I'm still thinking in terms of PHP and MySQL.If someone wants to have a look this is my fork: https://github.com/TimP4w/nodebb-plugin-ns-awards
For now it "works" but of course it's not production ready. -
@TimP4w I didn't prioritize any NodeBB development several last months. I have checked your PR at weekends, It's a definitely looks different. I thought about Achievement system in different way.
Would be great to know, how many users would like to see an achievement system (system where you define an achievement with a set of rules, and if those rules are fulfilled - user will receive an award).
-
-
@torn2 Just finished my exams, so I'll have time to continue this.
I think that with the last commit i've got it, there are just some other things to do i.e. beautify the ACP panel, the all awards page and also to add more rules, but the core thing is there. -
It looks like, ability to set achievements should not be a part of the Awards plugin.
In order to track several behaviors for every user in the system, plenty of additional database objects should be created. It's an overhead. Only who is interested in such resource overhead, only they should spend extra CPU/RAM resources for it.What does it mean?
- NS Awards plugin should provide an API
- New Achievement plugin should be introduced, where Achievement plugin can interact with NS Awards if needed.
-
-
You can make it like a daily cron that checks award conditions instead of checking all conditions all time.
-
Would love, love, love to see automated medals that function similarly to rewards, where it awards medals based on parameters.
-
I am testing
v1.4.0and have problems with this plugin. The award images are not being displayed in either the profile of the user or the topic that an awarded user starts.
The images do show up in the ACP for the plugin:
Is this a known problem with this plugin and the recent version of NodeBB?
-
-
@rod said in [nodebb-plugin-ns-awards] NS Awards, Give Medals!:
@rod I believe I found the problem. The path to the image is missing a dividing slash.
.../uploads/awards/award-...
Odd thing is that I cannot seem to figure out where to add the missing
/in the plugin code. -
I assume It was changed in NodeBB. That is why It does not work anymore for you in the latest version.
-
@Nicolas Your broken plugin was bothering me! I found a work around.
In my public directory I created a symbolic link to the proper directory with the broken directory path. Now the award images render properly.
This is what I did:
In the
publicdirectory I created the symlinkln -s uploads/awards uploadsawards -
Sorry for that.
In some particular version of the NodeBB, trailing slash was removed from the path.
With the next update, the path will be handled better. -
@Nicolas I'm not sure if you were still planning on doing an update, but I've made this plugin work with 1.4.5: https://github.com/NicolasSiver/nodebb-plugin-ns-awards/pull/13
It still needs some work on the ACP side, and you'd probably want to check out one of the hotfixes I made before merging (see issue).
I think you should check out NodeBB's
src/file.jsinstead of writing your own uploader though
Thanks! -
I had a feeling that it's not a good idea to do changes in the
master
I have started to work on the next major update, so a lot of parts of the plugin is not implemented or unfinished. Anyway, thanks for the pull-request.
