CPU utilization increased in 0.6.x

[hek]

@psychobunny

Ok, good to hear

Upgrade to 1.7 finished. I only had to disable the nodebb-plugin-topic-badges plugin as it resulted in crashes.

We got two search icons in the header now also. Is that "as designed"?

17/3 19:13 [14062] - error: TypeError: Object #<Object> has no method 'push'
    at Object.TopicBadges.addThreadTools [as method] (/usr/mysensors/mysensors-forum/NodeBB/node_modules/nodebb-plugin-topic-badges/library.js:27:15)
    at /usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:89:12
    at /usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:272:13
    at iterate (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:149:13)
    at Object.async.eachSeries (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:165:9)
    at Object.async.reduce (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:271:15)
    at fireFilterHook (/usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:81:9)
    at Plugins.fireHook (/usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:66:5)
    at Object.threadTools (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:656:23)
    at /usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:583:25

[baris]

You can disable the on on the left from ACP>navigation

[hek]

@baris

Ohh.. sweet a new menu for handling top bar!

There is something wrong with category permissions! Many of your categories is hidden for registered users/guests (only admin=me) can see it. Tried re-saving but this seems to make it even more worse (they disappear one by one). Panic!

[hek]

I have to enable old disabled categories to see them. Definitely a bug somewhere in the permission-on-categories part.

[hek]

Reset password does dot work any more. You only get a "invalid reset code" popup.

[hek]

File uploads does not quite work. They end up on server but they are not shown in posts. Only appear as:


Which plugin is responsible for parsing image tags? What could be the issue.

[hek]

I would say the filename with spaces "1426624191257-sensor shield rev 1.6 pcb.png " breaks the parsing.

Previously the files got names such as upload-2fd43287-38ca-4fb2-98c3-57120164d605.png

Panic:ing. Which component should I downgrade to get the old behaviour? marked?

[hek]

@baris and @psychobunny , just a gentle ping. Would love to have image uploads working again before I hit the bed here.

Do you remember when the file upload/filename last changed in master (or plugins).

[psychobunny]

Okay so Baris fixed the reset issue an hour or so ago, but I would not recommend updating to the latest master beyond that commit on a live forum

[psychobunny]

I hate to be the bearer of bad news but the other two issues are more oriented towards @baris and @julian who are AFK till the morning at worst. I hope you can cope (this is the reason why we don't recommend using a non-stable build)

Any chance of dropping back to latest stable (0.6x)? Do you have backups? Otherwise hang tight and we will try to resolve tomorrow?

[hek]

I can live without reset for a few days. Or cherrypick 37fe438c63359e9ce25a307aea48c752f0ce7c2a.

But image upload is worse.

[psychobunny]

For the category permissions its a bug I encountered myself earlier so pinging @julian for that.

The fix was going though every single category and updating the privs, check everything (ex. Read/find for guests, read/find/post/reply for everyone else). Its a pain in the ass but this will fix that for you right now.

We need to write an upgrade script

[hek]

Yes, have backups. But there will be post/user-losses going back.
The community just have to wait for tomorrow then.

Seems file upload works here but you send them away to imgur and the generated url looks "parsable" without any spaces.

[psychobunny]

@hek I'll make a couple issues on our tracker so its more visible. Welcome to the latest and greatest (and broken) master

[hek]

@psychobunny said:

@hek I'll make a couple issues on our tracker so its more visible. Welcome to the latest and greatest (and broken) master

Great. I feel welcome

[psychobunny]

[hek]

Hehe.. guess you need kamikaze pilots helping to smoke out those bugs at some point.

[hek]

Added some comments here:

https://github.com/NodeBB/NodeBB/commit/909fe660a910bd0448d615a1002e6dbcd052ee23

[Scuzz]

@a_5mith said:

@hek said:

Hi! Just took the leap to 0.6.x. A few thing I have noticed.

1. First time sitemap.xml is accessed NodeBB crashes. Second time works fine.
2. CPU usage went up ~10% on a 1GB digital ocean droplet.

4. We get plenty of these in the log:

Error: invalid csrf token
    at verifytoken (/usr/mysensors/mysensors-forum/NodeBB/node_modules/csurf/index.js:237:11)

5. Number of online users has dropped from ~250 to ~60. Has timeout times been changed?

Is 0.7.x out of the question for production use?

Feedback is appreciated.

Csrf could spell an out of date theme.

If you want stability, stick with stable. I use 0.7 on my live site. And it's used here. But, wouldn't recommend it.

What would i need to change on my theme to remove this csrf issue?

[psychobunny]

Is this your theme?

https://github.com/BitBangersCode/nodebb-theme-classic/blob/master/templates/header.tpl

Delete the header.tpl (in fact, you might want to just delete any templates that you haven't specifically modified) - this will result in your theme inheriting the original template from vanilla, which will make upgrades easier.

Otherwise, replay the commits here https://github.com/NodeBB/nodebb-theme-vanilla/commits/master/templates/header.tpl until you are inline with your core revision