CPU utilization increased in 0.6.x

hek

I would say the filename with spaces "1426624191257-sensor shield rev 1.6 pcb.png " breaks the parsing.

Previously the files got names such as upload-2fd43287-38ca-4fb2-98c3-57120164d605.png

Panic:ing. Which component should I downgrade to get the old behaviour? marked?

hek

@baris and @psychobunny , just a gentle ping. Would love to have image uploads working again before I hit the bed here.

Do you remember when the file upload/filename last changed in master (or plugins).

psychobunny

Okay so Baris fixed the reset issue an hour or so ago, but I would not recommend updating to the latest master beyond that commit on a live forum

psychobunny

I hate to be the bearer of bad news but the other two issues are more oriented towards @baris and @julian who are AFK till the morning at worst. I hope you can cope (this is the reason why we don't recommend using a non-stable build)

Any chance of dropping back to latest stable (0.6x)? Do you have backups? Otherwise hang tight and we will try to resolve tomorrow?

hek

I can live without reset for a few days. Or cherrypick 37fe438c63359e9ce25a307aea48c752f0ce7c2a.

But image upload is worse.

psychobunny

For the category permissions its a bug I encountered myself earlier so pinging @julian for that.

The fix was going though every single category and updating the privs, check everything (ex. Read/find for guests, read/find/post/reply for everyone else). Its a pain in the ass but this will fix that for you right now.

We need to write an upgrade script

hek

Yes, have backups. But there will be post/user-losses going back.
The community just have to wait for tomorrow then.

Seems file upload works here but you send them away to imgur and the generated url looks "parsable" without any spaces.

psychobunny

@hek I'll make a couple issues on our tracker so its more visible. Welcome to the latest and greatest (and broken) master

hek

@psychobunny said:

@hek I'll make a couple issues on our tracker so its more visible. Welcome to the latest and greatest (and broken) master

Great. I feel welcome

psychobunny

hek

Hehe.. guess you need kamikaze pilots helping to smoke out those bugs at some point.

hek

Added some comments here:

decodeURIComponent for uploaded file/image · NodeBB/NodeBB@909fe66

Node.js based forum software built for the modern web - decodeURIComponent for uploaded file/image · NodeBB/NodeBB@909fe66

GitHub (github.com)

Scuzz

@a_5mith said:

@hek said:
Hi! Just took the leap to 0.6.x. A few thing I have noticed.

First time sitemap.xml is accessed NodeBB crashes. Second time works fine.

CPU usage went up ~10% on a 1GB digital ocean droplet.

We get plenty of these in the log:
Error: invalid csrf token
    at verifytoken (/usr/mysensors/mysensors-forum/NodeBB/node_modules/csurf/index.js:237:11)
Number of online users has dropped from ~250 to ~60. Has timeout times been changed?

Is 0.7.x out of the question for production use?

Feedback is appreciated.
Csrf could spell an out of date theme.

If you want stability, stick with stable. I use 0.7 on my live site. And it's used here. But, wouldn't recommend it.

What would i need to change on my theme to remove this csrf issue?

psychobunny

Is this your theme?

nodebb-theme-classic/templates/header.tpl at master · BitBangersCode/nodebb-theme-classic

A classic theme for NodeBB. Contribute to BitBangersCode/nodebb-theme-classic development by creating an account on GitHub.

GitHub (github.com)

Delete the header.tpl (in fact, you might want to just delete any templates that you haven't specifically modified) - this will result in your theme inheriting the original template from vanilla, which will make upgrades easier.

Otherwise, replay the commits here https://github.com/NodeBB/nodebb-theme-vanilla/commits/master/templates/header.tpl until you are inline with your core revision

Scuzz

@psychobunny The most current version is on the 0.6.x branch - https://github.com/BitBangersCode/nodebb-theme-classic/blob/0.6.x/templates/header.tpl

I'm not entirely sure on what needs to be kept in the the header.tpl as i have forked it from someone else. I will update it to match the current vanilla header or remove it. Removing it will probably be easier but i will need to test it out first.

Thanks for the help!

hek

Group Badges on users seems to have disappeared in 0.7. Is there some new option to re-enable this that I haven't found?

codejet

@hek said:

Group Badges on users seems to have disappeared in 0.7. Is there some new option to re-enable this that I haven't found?

Having probs on the latest dev branch also, click [ join group] popup message top left says Group does not exist.. strange

also noticed that change icon and change color buttons don't work

<baris>

@hek user can now go into their settings and pick one title to display instead of displaying all the titles.

hek

@baris

Ok! thanks.

Kind of liked the old thing were I could "promote" users with badges. Now they have to activate them as well which makes it a bit more complicated.

<baris>

Yeah we were running into issues on forums with lots of groups display all the titles.

If you want you can go back to the old behavior by modifying https://github.com/NodeBB/NodeBB/blob/master/src/posts/user.js#L46

Change that line to selected: true and it should display all groups.