Can I have a plugin send notifications that are not topic related?

[baris]

Yeah just create the notification with notifications.create then use notifications.pushGroup and pass the notification object.

notifications.create({
  nid: 'plugin:new_user:' + theiruid, // a unique notification id
  bodyShort: 'a new user is waiting approval'
  path: 'admin/plugins/approval', //clickin the notification will take user to this link
  from: theiruid // this will cause the new users image to appear with the notification
}, function(err, notification) {
   if (err) {
      return callback(err);
   }
   notifications.pushGroup(notification, 'administrators', callback);
});

[pichalite]

@baris thanks. Creating the notification works but when I click on the notification, it takes me to admin/plugins/approval but with client css applied and settings don't get loaded. Refreshing the page applies the admin css and displays ACP menu.

[baris]

Does it ajaxify to admin/plugins/approval? It should do a cold load, if not we should fix that.

[pichalite]

@baris It does not do a cold load. This is what it looks like when I click on the notification.

[baris]

Sounds like notifications need a way to open the link in a new tab.

[PitaJ]

@baris you should detect whenever anything is going to /admin/... and automatically open it in a new tab.

[julian]

@pitaj @pichalite gh#2849

[pichalite]

@julian one problem. when I click on the notification, it's opening the same link in current tab and in a new tab.

[PitaJ]

@pichalite looking at the code, that shouldn't be happening. Hmmm...

[baris]

Should be fixed in https://github.com/NodeBB/NodeBB/commit/ca31ac882ca1177afdfb077adf4235c5c48924d0

[pichalite]

@baris doesn't seem to be fixed. Still same issue.

[julian]

Is the relevant code in public/src/ajaxify?

[baris]

@pichalite Try with https://github.com/NodeBB/NodeBB/commit/f89741636cdad244d38bf2c8dca52054f65c335c

Let me know if that works.

[pichalite]

@baris no luck.

yes @julian the relevant code is in public/src/ajaxify

FYI I'm on latest NodeBB master, vanilla & lavender

[baris]

Can you try again on latest.

[pichalite]

@baris works now, thanks.