@a_5mith Sweet, I kind of had that aching feeling, so I'll spare the extra work for now and wait for the release. I'll keep an eye out for the transfix update as well, is it supposed to collide (transifex update) with the release? I'd think the first might come a bit before the second, if only for giving translators the time to write something up before the release (unless you guys cook up the baseline translations yourself internally first). Oh well, anyway, thanks for the update !
middleware.admin.isAdmin is not needed
In your plugins you don't have to call
middleware.admin.isAdminthis is already handled in core at https://github.com/NodeBB/NodeBB/blob/master/src/routes/index.js#L122-L123
Same with middleware.applyCSRF this is called on admin routes as well.
user.isAdministrator also exists. Do they perform the same function?
isAdmin()is the middleware, whereas
isAdministratoris the library method. They are functionally similar, except the middleware handles redirecting the user to