3.7.0 Upgrade Support

[crazycells]

replied to baris does not look correct...

[crazycells]

I just realized it is probably not related to NodeBB v3.7 , I guess it is related to ActivityPub integration?

[crazycells]

we have successfully upgraded our dev forum, but have a few error and warning messages in the logs... anything to worry about?

2024-03-06T17:57:56.475Z [4567/391] - info: [app] Shutdown (SIGTERM/SIGINT/SIGQUIT) Initialised.
2024-03-06T17:57:56.476Z [4567/391] - info: [app] Web server closed to connections.
2024-03-06T17:57:56.478Z [4567/391] - info: [app] Live analytics saved.
2024-03-06T17:57:56.489Z [4567/391] - info: [app] Database connection closed.
2024-03-06T17:57:56.489Z [4567/391] - info: [app] Shutdown complete.
[cluster] Child Process (391) has exited (code: 0, signal: null)

NodeBB v3.7.0 Copyright (C) 2013-2024 NodeBB Inc.
This program comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it under certain conditions.
For the full license, please visit: http://www.gnu.org/copyleft/gpl.html

Clustering enabled: Spinning up 1 process(es).

2024-03-06T17:57:57.012Z [4567/669] - info: Initializing NodeBB v3.7.0 https://dev.XXXXX
node:events:496
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at target._send (node:internal/child_process:879:20)
    at target.send (node:internal/child_process:752:19)
    at process.<anonymous> (/home/fsuzer/nodebb/src/meta/minifier.js:118:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Emitted 'error' event on process instance at:
    at node:internal/child_process:883:39
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}

Node.js v20.11.1
2024-03-06T17:57:57.980Z [4567/669] - info: [socket.io] Restricting access to origin: https://XXXXX*
2024-03-06T17:57:58.106Z [4567/669] - info: [api] Adding 0 route(s) to `api/v3/plugins`
2024-03-06T17:57:58.113Z [4567/669] - info: [router] Routes added
2024-03-06T17:57:58.117Z [4567/669] - info: 🎉 NodeBB Ready
2024-03-06T17:57:58.118Z [4567/669] - info: 🤝 Enabling 'trust proxy'
2024-03-06T17:57:58.119Z [4567/669] - info: 📡 NodeBB is now listening on: 0.0.0.0:4567
2024-03-06T17:57:58.119Z [4567/669] - info: 🔗 Canonical URL: https://dev.XXXXX
WARNING: The keyword 'none' must be used as a single argument.
    ../../../bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
    ../../../bootstrap/scss/forms/_form-control.scss 40:7  @import
    bootstrap/scss/_forms.scss 3:9                         @import
    - 19:9                                                 root stylesheet

WARNING: The keyword 'none' must be used as a single argument.
    ../../../bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
    ../../../bootstrap/scss/forms/_form-select.scss 32:7  @import
    bootstrap/scss/_forms.scss 4:9                        @import
    - 19:9                                                root stylesheet

[crazycells]

we started to get this error message...

2024-03-06T18:09:53.523Z [4567/1192] - error: [acp] Failed to fetch latest versionError: rate limit exceeded
    at getLatestVersion (/home/fsuzer/nodebb/src/admin/versions.js:30:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getLatestVersion (/home/fsuzer/nodebb/src/middleware/render.js:500:11)
    at async Promise.all (index 4)
    at async loadAdminHeaderFooterData (/home/fsuzer/nodebb/src/middleware/render.js:253:19)
    at async loadHeaderFooterData (/home/fsuzer/nodebb/src/middleware/render.js:137:11)
    at async renderMethod (/home/fsuzer/nodebb/src/middleware/render.js:87:30)
    at async ServerResponse.renderOverride [as render] (/home/fsuzer/nodebb/src/middleware/render.js:111:5)
2024-03-06T18:09:58.052Z [4567/1192] - error: [acp] Failed to fetch latest version
Error: rate limit exceeded
    at getLatestVersion (/home/fsuzer/nodebb/src/admin/versions.js:30:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getLatestVersion (/home/fsuzer/nodebb/src/controllers/admin/dashboard.js:82:10)
    at async Promise.all (index 2)
    at async dashboardController.get (/home/fsuzer/nodebb/src/controllers/admin/dashboard.js:22:81)
    at async /home/fsuzer/nodebb/src/routes/helpers.js:78:5

[crazycells]

well, after several rounds of rebuilding and restarting it looks like it is fixed...

[baris]

@crazycells https://github.com/NodeBB/NodeBB/issues/6540

[julian]

@crazycells Yeah, @baris uses characters in his display name to test escaping... it looks like it is double-escaped when sent via ActivityPub.

Unrelated to v3.7.0

[cagatay]

updated without problem.
thank you @baris & @julian

[phenomlab]

@cagatay You should re-check your site. NodeBB 3.7.0 has breaking changes for this my extension - "Threaded Posts" because of the changes to the HTML structure in the posts view.

The result is that the Threaded Posts extension fails to render as the target has changed. See below for a fix

https://sudonix.org/topic/569/threaded-post-support-for-nodebb/143

[crazycells]

Hi @baris , I have a comment and a question about the navigation menu panel on mobile... what would be the easiest way to make this menu panel larger/longer on mobile?

I guess this is designed to be part of the "harmony" theme, but I believe a longer menu panel would be way more efficient. When someone wants to see the menu, I think it would make more sense to see all (or as many as possible) options at the same time, rather than opening a smaller panel? Basically, I do not need to see the background while I am selecting a menu option, right? Anyways, I respect the designer however, I would like to change the length of this menu panel on mobile for our forum without breaking anything else is there an easy way to achieve this? Thanks...

[phenomlab]

@crazycells that can easily be achieved using css.

[crazycells]

@phenomlab then, please help I checked the developer tools, but failed to understand which parameters are determining this height...

[phenomlab]

@crazycells let me have a look at this later today

[crazycells]

@phenomlab said in 3.7.0 Upgrade Support:

@crazycells let me have a look at this later today

lol, I am ashamed to say this but I think I figured it out, and it was very easy... I believe this is the code?

.bottombar-nav .navigation-dropdown, .bottombar-nav .user-dropdown {
  max-height: 80vh !important;
}

Apparently, I was looking at the wrong parts of the CSS codes...

[phenomlab]

@crazycells yes, that would have been my suggestion to use vh to control the height.

[crazycells]

@crazycells well, it is coded to be 60vh, I have changed it to 80vh...

I guess navigation dropdown is the left panel, and user dropdown is the right panel?

[phenomlab]

@crazycells if I recall correctly, yes

[crazycells]

I have encountered several issues while using the website on mobile, the bottom bar prevents the visibility of bottom sheet options

1. When browsing sub-category options, tags/categories/topics filters, the bottom bar prevents the options from being fully visible on the screen. Sometimes, it doesn't appear on the first click, but the issue becomes more apparent when clicking on tags, categories, and filters sequentially. After clicking on the tag button, when categories are selected, the bottom bar reappears and prevents the visibility of all options.

2. When using the website as a PWA, the tags list doesn't extend to the bottom of the screen. I have to manually pull the screen and drag it up to see the last tag options.

3. This is more of an aesthetic critique rather than a bug... the tag screen on mobile uses excessive space unnecessarily. I suggest implementing two columns of tags instead of one, allowing for twice as many options to be visible on mobile screens at any time.

[crazycells]

additionally, can you please extend this pagination bar on mobile for topics list? some of us have sausage fingers and cannot click on such a small area easily... lol...

moreover, I guess you may want to update twitter logo to X...

[phenomlab]

@crazycells