3.4.0 Upgrade Support

[baris]

@TaLoche what's the rest of the stack trace?

[TaLoche]

Hi @baris thanks for your help (on a Sunday!)

GET https://xxx.com/api/user/taloche/chats/35?_=1694955865278
[HTTP/1.1 500 Internal Server Error 0ms]

send https://xxx.com/assets/nodebb.min.js:58:8776
ajax https://xxx.com/assets/nodebb.min.js:58:5246
28234/ajaxify.loadData https://xxx.com/assets/nodebb.min.js:7:25610
28234/ajaxify.go https://xxx.com/assets/nodebb.min.js:7:20095
j https://xxx.com/assets/nodebb.min.js:7:27886
28234/</c/< https://xxx.com/assets/nodebb.min.js:7:29089
dispatch https://xxx.com/assets/nodebb.min.js:55:40362
19755/</add/Pe.handle ttps://xxx.com/assets/nodebb.min.js:55:38293

[baris]

@TaLoche you should look at the logs on the server in the file. /path/to/nodebb/logs/output.log

[TaLoche]

Thanks!
I did but didn't look carefully enough.
Indeed this error can be found

2023-09-17T13:12:57.254Z [4567/838953] - error: GET /api/user/taloche/chats/35?_=1694956368722 TypeError: Cannot read properties of undefined (reading 'push') at plugin.filterMessagingLoadRoom [as method] (/var/www/nodebb/node_modules/nodebb-plugin-tenor-gif/library.js:50:31) at /var/www/nodebb/src/plugins/hooks.js:176:29 at new Promise (<anonymous>) at fireMethod (/var/www/nodebb/src/plugins/hooks.js:166:10) at Object.fireFilterHook [as filter] (/var/www/nodebb/src/plugins/hooks.js:195:18) at Hooks.fire (/var/www/nodebb/src/plugins/hooks.js:132:49) at Object.wrapperCallback [as fire] (/var/www/nodebb/src/promisify.js:46:11) at Messaging.loadRoom (/var/www/nodebb/src/messaging/rooms.js:538:39) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async chatsController.get (/var/www/nodebb/src/controllers/accounts/chats.js:51:15)

[TaLoche]

With the plugin disabled and a restart, everything works again!

nodebb-plugin-tenor-gif

[baris]

You can upgrade to the latest version of tenor-gif with npm i nodebb-plugin-tenor-gif@latest and it should be fixed.

[TaLoche]

You're the best!
Thanks @baris

with version 3.1.5 for nodebb-plugin-tenor-gif everything is in order.

[brazzerstop]

When choose tags, forum didn't found topics with this tags...

[baris]

The tag filter shows topic that have all the tags selected, for example https://community.nodebb.org/category/2/general-discussion?tag[]=nodebb&tag[]=feature

[brazzerstop]

I think this method is a bad practices for users, for example I have a 10 topics with one tag for all topics - smartphones and individual tags ios, android, harmonyos, windows.

When user want found all topics with tags ios and android the forum will not find anything, because the filter is an employee on the principle of tag1 + tag2 + tag3.

But we understand if user select ios and android he want found all topics with ios OR android

The advanced search /search it too can't found a all topics with multiple tags...

[baris]

On the /search page we might be able to add an option into the tag dropdown to specify if you want find topics that has all the tags or any of them . Right now it is only returning results that has all the tags that you specify.

[brazzerstop]

Can't disable this option, I'm try set 0 or empty value in settings and it's not disable this alert...

[baris]

@brazzerstop https://github.com/NodeBB/NodeBB/issues/12052

[brazzerstop]

Search button in navbar not showing for guest if allow search for all group in setting.

offtopic

[baris]

@brazzerstop filed an issue https://github.com/NodeBB/NodeBB/issues/12056

[josef]

@brazzerstop said in 3.4.0 Upgrade Support:

I think this method is a bad practices for users, for example I have a 10 topics with one tag for all topics - smartphones and individual tags ios, android, harmonyos, windows.

Totally agree, the expected behavior is for it to work like the category filter on the topics page, you can select multiple categories and it shows topics from each of them (or in this case, multiple tags)

[brazzerstop]

How search looks for guest

[baris]

@brazzerstop https://github.com/NodeBB/nodebb-theme-harmony/commit/1e5c994ea7cce867108d13ad5c197afe6eb734a9

[crazycells]

hi @baris , is there any reason that the stale topic function cannot be disabled?

We already have the necro threshold set, so I would like to set it to "0" to disable this function, if technically possible, I will open a GH issue.

[julian]

I think he actually just did this