NodeBB 3.4.0

[baris]

Next release is going to be 3.5.0

[brazzerstop]

I think we need fix container size for tablets, current we have very big empty place on left and right...

https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/header.tpl#L42
https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/header/brand.tpl#L2

Replace container to container-lg

Before (topic)

After (topic)

Before (categories)

After (categories)

[crazycells]

hi @julian , is this plugin compatible with v3?

GitHub - julianlam/nodebb-plugin-support-forum: Turns a single category into a "Support Forum", topic creators can only see their own topics

Turns a single category into a "Support Forum", topic creators can only see their own topics - julianlam/nodebb-plugin-support-forum

GitHub (github.com)

[brazzerstop]

NodeBB began the transition to NodeJS v18? So, we can say bye-bye to resource econony Ubuntu 18.04

Updating NodeBB...

1. Updating package.json file with defaults...  OK

2. Bringing base dependencies up to date...  started
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.12.0' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

changed 2 packages, and audited 1106 packages in 5s

138 packages are looking for funding
  run `npm fund` for details

10 moderate severity vulnerabilities

[PitaJ]

@brazzerstop lint-staged is a dev-dependency, not sure why it's showing up there but you can safely ignore that warning.

[brazzerstop]

@PitaJ
Yes, I am using the develop version and regardless of the warning, I successfully updated, and so far everything is working on version NodeJS 16.

But I will still be preparing to move to Ubuntu 20.04 so that I can install the 18th version of the NodeJS, because it seems to me that the NodeBB will gradually increase the requirements to dependencies for security reasons.

[baris]

@brazzerstop https://github.com/NodeBB/NodeBB/issues/12107.

Node 16 is end of life so it's a good idea to start migrating to 18.

[sweetp]

I’m running on Node 21 without issue

[sweetp]

although I do have a bunch of warnings:

(node:1542010) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.

[baris]

@sweetp If you run nodebb with the --throw-deprecation flag then it should throw an error instead of a warning, that should hopefully show us the stack trace where it is happening.

[sweetp]

@Baris here's a different error, ill keep trying to generate the other error I also mentioned:

2023-10-22T18:45:39.710Z [4568/2336493] - error: uncaughtException: The `punycode` module is deprecated. Please use a userland alternative instead.
DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)
    at loadBuiltinModule (node:internal/modules/helpers:102:7)
    at Module._load (node:internal/modules/cjs/loader:995:17)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10) {"date":"Sun Oct 22 2023 20:45:39 GMT+0200 (Central European Summer Time)","error":{"code":"DEP0040","name":"DeprecationWarning"},"exception":true,"os":{"loadavg":[0.45,0.28,0.12],"uptime":1000799.34},"process":{"argv":["/opt/plesk/node/21/bin/node","/var/www/vhosts/mysite.com/NodeBB/app.js"],"cwd":"/var/www/vhosts/mysite.com/NodeBB","execPath":"/opt/plesk/node/21/bin/node","gid":1003,"memoryUsage":{"arrayBuffers":533115,"external":4010196,"heapTotal":82853888,"heapUsed":56554376,"rss":145403904},"pid":2336493,"uid":10011,"version":"v21.0.0"},"stack":"DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.\n    at node:punycode:3:9\n    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)\n    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)\n    at loadBuiltinModule (node:internal/modules/helpers:102:7)\n    at Module._load (node:internal/modules/cjs/loader:995:17)\n    at Module.require (node:internal/modules/cjs/loader:1229:19)\n    at require (node:internal/modules/helpers:177:18)\n    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)\n    at Module._compile (node:internal/modules/cjs/loader:1369:14)\n    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)","trace":[{"column":9,"file":"node:punycode","function":null,"line":3,"method":null,"native":false},{"column":7,"file":"node:internal/bootstrap/realm","function":"BuiltinModule.compileForInternalLoader","line":392,"method":"compileForInternalLoader","native":false},{"column":10,"file":"node:internal/bootstrap/realm","function":"BuiltinModule.compileForPublicLoader","line":328,"method":"compileForPublicLoader","native":false},{"column":7,"file":"node:internal/modules/helpers","function":"loadBuiltinModule","line":102,"method":null,"native":false},{"column":17,"file":"node:internal/modules/cjs/loader","function":"Module._load","line":995,"method":"_load","native":false},{"column":19,"file":"node:internal/modules/cjs/loader","function":"Module.require","line":1229,"method":"require","native":false},{"column":18,"file":"node:internal/modules/helpers","function":"require","line":177,"method":null,"native":false},{"column":16,"file":"/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js","function":null,"line":5,"method":null,"native":false},{"column":14,"file":"node:internal/modules/cjs/loader","function":"Module._compile","line":1369,"method":"_compile","native":false},{"column":10,"file":"node:internal/modules/cjs/loader","function":"Module._extensions..js","line":1427,"method":".js","native":false}]}
2023-10-22T18:45:39.711Z [4568/2336493] - error: DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:392:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:328:10)
    at loadBuiltinModule (node:internal/modules/helpers:102:7)
    at Module._load (node:internal/modules/cjs/loader:995:17)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/node_modules/psl/index.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
2023-10-22T18:45:39.711Z [4568/2336493] - info: [app] Shutdown (SIGTERM/SIGINT/SIGQUIT) Initialised.
2023-10-22T18:45:39.825Z [4568/2336493] - error: TypeError: ttl must be positive integer or Infinity if set
    at new TTLCache (/var/www/vhosts/mysite.com/NodeBB/node_modules/@isaacs/ttlcache/index.js:35:13)
    at module.exports (/var/www/vhosts/mysite.com/NodeBB/src/cache/ttl.js:7:19)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/src/middleware/uploads.js:8:15)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1201:32)
    at Module._load (node:internal/modules/cjs/loader:1017:12)
    at Module.require (node:internal/modules/cjs/loader:1229:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/var/www/vhosts/mysite.com/NodeBB/src/middleware/index.js:67:22)

[sweetp]

@baris here's the original warning:

(node:2339958) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
    at node:internal/util:443:17
    at new Promise (<anonymous>)
    at Object.buildHeaderAsync (node:internal/util:428:12)
    at exports.send404 (/var/www/vhosts/mysite.com/NodeBB/src/controllers/404.js:62:19)
    at handle404 (/var/www/vhosts/mysite.com/NodeBB/src/controllers/404.js:41:11)
    at Layer.handle [as handle_request] (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:328:13)
    at /var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:346:12)
    at next (/var/www/vhosts/mysite.com/NodeBB/node_modules/express/lib/router/index.js:280:10)

[baris]

@sweetp This warning should be fixed in 3.5.0

[stationary_code]

Hello, I am currently using 3.5.0 and this message is currently spamming the log.

(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.
(node:37195) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.

[baris]

@stationary_code see the post https://community.nodebb.org/post/96530 and start nodebb with that flag, then it should show you the stack trace.

[crazycells]

@baris thanks @baris , that warning is gone, but we have this long list every time restarting the forum... is this normal?

  started
2023-11-09T17:06:11.039Z [4567/441810] - info: [build] Building in series mode
2023-11-09T17:06:11.040Z [4567/441810] - info: [build]         plugin static dirs  build started
2023-11-09T17:06:11.051Z [4567/441810] - info: [build]         plugin static dirs  build completed in 0.011sec
2023-11-09T17:06:11.051Z [4567/441810] - info: [build]          requirejs modules  build started
2023-11-09T17:06:11.153Z [4567/441810] - info: [build]          requirejs modules  build completed in 0.102sec
2023-11-09T17:06:11.154Z [4567/441810] - info: [build]           client js bundle  build started
2023-11-09T17:06:11.161Z [4567/441810] - info: [build]           client js bundle  build completed in 0.007sec
2023-11-09T17:06:11.162Z [4567/441810] - info: [build]            admin js bundle  build started
2023-11-09T17:06:11.166Z [4567/441810] - info: [build]            admin js bundle  build completed in 0.004sec
2023-11-09T17:06:11.167Z [4567/441810] - info: [build]         client side styles  build started
2023-11-09T17:06:15.527Z [4567/441810] - info: [build]         client side styles  build completed in 4.36sec
2023-11-09T17:06:15.528Z [4567/441810] - info: [build] admin control panel styles  build started
2023-11-09T17:06:17.884Z [4567/441810] - info: [build] admin control panel styles  build completed in 2.356sec
2023-11-09T17:06:17.884Z [4567/441810] - info: [build]                  templates  build started
2023-11-09T17:06:18.633Z [4567/441810] - info: [build]                  templates  build completed in 0.749sec
2023-11-09T17:06:18.633Z [4567/441810] - info: [build]                  languages  build started
2023-11-09T17:06:21.053Z [4567/441810] - info: [build]                  languages  build completed in 2.42sec
2023-11-09T17:06:21.053Z [4567/441810] - info: [build] Bundling with Webpack.

[1%] setup (before run)
[1%] setup (before run NodeEnvironmentPlugin)
[1%] setup (before run)
[2%] setup (run)
[4%] setup (normal module factory)
[5%] setup (context module factory)
[6%] setup (before compile)
[6%] setup (before compile ProgressPlugin)
[6%] setup (before compile)
[7%] setup (compile)
[7%] setup (compile ExternalsPlugin)
[7%] setup (compile)
[8%] setup (compilation)
[8%] setup (compilation ArrayPushCallbackChunkFormatPlugin)
[8%] setup (compilation JsonpChunkLoadingPlugin)
[8%] setup (compilation StartupChunkDependenciesPlugin)
[8%] setup (compilation ImportScriptsChunkLoadingPlugin)
[8%] setup (compilation FetchCompileWasmPlugin)
[8%] setup (compilation FetchCompileAsyncWasmPlugin)
[8%] setup (compilation WorkerPlugin)
[8%] setup (compilation SplitChunksPlugin)
[8%] setup (compilation ResolverCachePlugin)
[8%] setup (compilation)
[9%] setup (compilation)
[9%] setup (compilation ProgressPlugin)
[9%] setup (compilation ChunkPrefetchPreloadPlugin)
[9%] setup (compilation JavascriptModulesPlugin)
[9%] setup (compilation JsonModulesPlugin)
[9%] setup (compilation AssetModulesPlugin)
[9%] setup (compilation EntryPlugin)
[9%] setup (compilation RuntimePlugin)
[9%] setup (compilation InferAsyncModulesPlugin)
[9%] setup (compilation DataUriPlugin)
[9%] setup (compilation FileUriPlugin)
[9%] setup (compilation CompatibilityPlugin)
[9%] setup (compilation HarmonyModulesPlugin)
[9%] setup (compilation AMDPlugin)
[9%] setup (compilation RequireJsStuffPlugin)
[9%] setup (compilation CommonJsPlugin)
[9%] setup (compilation LoaderPlugin)
[9%] setup (compilation NodeStuffPlugin)
[9%] setup (compilation APIPlugin)
[9%] setup (compilation ExportsInfoApiPlugin)
[9%] setup (compilation WebpackIsIncludedPlugin)
[9%] setup (compilation ConstPlugin)
[9%] setup (compilation UseStrictPlugin)
[9%] setup (compilation RequireIncludePlugin)
[9%] setup (compilation RequireEnsurePlugin)
[9%] setup (compilation RequireContextPlugin)
[9%] setup (compilation ImportPlugin)
[9%] setup (compilation ImportMetaContextPlugin)
[9%] setup (compilation SystemPlugin)
[9%] setup (compilation ImportMetaPlugin)
[9%] setup (compilation URLPlugin)
[9%] setup (compilation DefaultStatsFactoryPlugin)
[9%] setup (compilation DefaultStatsPresetPlugin)
[9%] setup (compilation DefaultStatsPrinterPlugin)
[9%] setup (compilation JavascriptMetaInfoPlugin)
[9%] setup (compilation EnsureChunkConditionsPlugin)
[9%] setup (compilation RemoveEmptyChunksPlugin)
[9%] setup (compilation MergeDuplicateChunksPlugin)
[9%] setup (compilation FlagIncludedChunksPlugin)
[9%] setup (compilation SideEffectsFlagPlugin)
[9%] setup (compilation FlagDependencyExportsPlugin)
[9%] setup (compilation FlagDependencyUsagePlugin)
[9%] setup (compilation InnerGraphPlugin)
[9%] setup (compilation MangleExportsPlugin)
[9%] setup (compilation ModuleConcatenationPlugin)
[9%] setup (compilation NoEmitOnErrorsPlugin)
[9%] setup (compilation RealContentHashPlugin)
[9%] setup (compilation WasmFinalizeExportsPlugin)
[9%] setup (compilation DeterministicModuleIdsPlugin)
[9%] setup (compilation DeterministicChunkIdsPlugin)
[9%] setup (compilation DefinePlugin)
[9%] setup (compilation TerserPlugin)
[9%] setup (compilation TemplatedPathPlugin)
[9%] setup (compilation RecordIdsPlugin)
[9%] setup (compilation WarnCaseSensitiveModulesPlugin)
[9%] setup (compilation)
[10%] building 
[10%] building (0/0 modules)
[10%] building (0/5 modules)
[10%] building (7/573 modules)
[10%] building (200/627 modules)
[10%] building (403/644 modules)
[10%] building (441/688 modules)
[10%] building (import loader file-loader/dist/cjs.js)
[10%] building (542/708 modules)
[10%] building (600/797 modules)
[10%] building (741/847 modules)
[10%] building (940/1135 modules)
[38%] building (1185/1186 modules)
[65%] building (1186/1186 modules)
[65%] building 
[69%] building (finish)
[70%] sealing (finish module graph)
[70%] sealing (finish module graph ResolverCachePlugin)
[70%] sealing (finish module graph InferAsyncModulesPlugin)
[70%] sealing (finish module graph FlagDependencyExportsPlugin)
[70%] sealing (finish module graph InnerGraphPlugin)
[70%] sealing (finish module graph WasmFinalizeExportsPlugin)
[70%] sealing (finish module graph)
[71%] sealing (plugins)
[71%] sealing (plugins WarnCaseSensitiveModulesPlugin)
[71%] sealing (plugins)
[71%] sealing (dependencies optimization)
[71%] sealing (dependencies optimization SideEffectsFlagPlugin)
[71%] sealing (dependencies optimization FlagDependencyUsagePlugin)
[71%] sealing (dependencies optimization)
[72%] sealing (after dependencies optimization)
[73%] sealing (chunk graph)
[73%] sealing (after chunk graph)
[74%] sealing (optimizing)
[74%] sealing (module optimization)
[75%] sealing (after module optimization)
[76%] sealing (chunk optimization)
[76%] sealing (chunk optimization EnsureChunkConditionsPlugin)
[76%] sealing (chunk optimization RemoveEmptyChunksPlugin)
[76%] sealing (chunk optimization MergeDuplicateChunksPlugin)
[76%] sealing (chunk optimization SplitChunksPlugin)
[76%] sealing (chunk optimization RemoveEmptyChunksPlugin)
[76%] sealing (chunk optimization)
[76%] sealing (after chunk optimization)
[77%] sealing (module and chunk tree optimization)
[78%] sealing (after module and chunk tree optimization)
[78%] sealing (chunk modules optimization)
[78%] sealing (chunk modules optimization ModuleConcatenationPlugin)
[78%] sealing (chunk modules optimization)
[79%] sealing (after chunk modules optimization)
[80%] sealing (module reviving)
[80%] sealing (module reviving RecordIdsPlugin)
[80%] sealing (module reviving)
[80%] sealing (before module ids)
[81%] sealing (module ids)
[81%] sealing (module ids DeterministicModuleIdsPlugin)
[81%] sealing (module ids)
[82%] sealing (module id optimization)
[82%] sealing (module id optimization)
[83%] sealing (chunk reviving)
[83%] sealing (chunk reviving RecordIdsPlugin)
[83%] sealing (chunk reviving)
[83%] sealing (before chunk ids)
[84%] sealing (chunk ids)
[84%] sealing (chunk ids DeterministicChunkIdsPlugin)
[84%] sealing (chunk ids)
[85%] sealing (chunk id optimization)
[85%] sealing (chunk id optimization FlagIncludedChunksPlugin)
[85%] sealing (chunk id optimization)
[85%] sealing (after chunk id optimization)
[86%] sealing (record modules)
[86%] sealing (record modules RecordIdsPlugin)
[86%] sealing (record modules)
[87%] sealing (record chunks)
[87%] sealing (record chunks RecordIdsPlugin)
[87%] sealing (record chunks)
[87%] sealing (module hashing)
[88%] sealing (code generation)
[89%] sealing (runtime requirements)
[89%] sealing (hashing)
[90%] sealing (after hashing)
[91%] sealing (record hash)
[91%] sealing (module assets processing)
[92%] sealing (chunk assets processing)
[92%] sealing (asset processing)
[92%] sealing (asset processing TerserPlugin)
[92%] sealing (asset processing RealContentHashPlugin)
[92%] sealing (asset processing)
[93%] sealing (after asset optimization)
[94%] sealing (recording)
[94%] sealing (after seal)
[95%] emitting (emit)
[95%] emitting (emit CleanPlugin)
[95%] emitting (emit)
[98%] emitting (after emit)
[98%] emitting (after emit SizeLimitsPlugin)
[98%] emitting (after emit)
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
Build finished at 17:06:33 by 0.000s
726 assets
1212 modules

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (500 KiB). This can impact web performance.
Entrypoints:
  admin (552 KiB)
      admin.min.js

webpack 5.89.0 compiled with 1 warning in 11628 ms
2023-11-09T17:06:33.192Z [4567/441810] - info: [build] Asset compilation successful. Completed in 22.146sec.
[cluster] Restarting...
Clustering enabled: Spinning up 1 process(es).

2023-11-09T17:06:33.208Z [4567/441810] - info: [app] Shutdown (SIGTERM/SIGINT/SIGQUIT) Initialised.
2023-11-09T17:06:33.212Z [4567/441810] - info: [app] Web server closed to connections.
2023-11-09T17:06:33.216Z [4567/441810] - info: [app] Live analytics saved.
2023-11-09T17:06:33.224Z [4567/441810] - info: [app] Database connection closed.
2023-11-09T17:06:33.224Z [4567/441810] - info: [app] Shutdown complete.
[cluster] Child Process (441810) has exited (code: 0, signal: null)
2023-11-09T17:06:33.494Z [4567/442082] - info: Initializing NodeBB v3.5.0 https://cihan.io/forum
2023-11-09T17:06:35.012Z [4567/442082] - info: [socket.io] Restricting access to origin: https://cihan.io:*
2023-11-09T17:06:35.632Z [4567/442082] - warn: [helpers.setupPageRoute(/glossary)] passing `middleware` as the third param is deprecated, it can now be safely removed
2023-11-09T17:06:35.633Z [4567/442082] - warn: [helpers.setupAdminPageRoute(/admin/plugins/glossary)] passing `middleware` as the third param is deprecated, it can now be safely removed
2023-11-09T17:06:35.675Z [4567/442082] - info: [api] Adding 0 route(s) to `api/v3/plugins`
2023-11-09T17:06:35.696Z [4567/442082] - info: [router] Routes added
2023-11-09T17:06:35.717Z [4567/442082] - info: 🎉 NodeBB Ready
2023-11-09T17:06:35.720Z [4567/442082] - info: 🤝 Enabling 'trust proxy'
2023-11-09T17:06:35.723Z [4567/442082] - info: 📡 NodeBB is now listening on: 0.0.0.0:4567
2023-11-09T17:06:35.723Z [4567/442082] - info: 🔗 Canonical URL: https://cihan.io/forum
WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9   box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-control.scss 40:7  @import
    bootstrap/scss/_forms.scss 3:9                                   @import
    - 19:9                                                           root stylesheet

WARNING: The keyword 'none' must be used as a single argument.
    ../../node_modules/bootstrap/scss/mixins/_box-shadow.scss 10:9  box-shadow()
    ../../node_modules/bootstrap/scss/forms/_form-select.scss 32:7  @import
    bootstrap/scss/_forms.scss 4:9                                  @import
    - 19:9                                                          root stylesheet

[baris]

Yeah I think, that's normal, a recent change started adding the output of ./nodebb upgrade into output.log too. That's what you are seeing I think.

[crazycells]

hi @baris , on .../admin/extend/rewards page, is it possible to convert rewards panel into movable panels? if they are mobile, it would be easier to group them into sections... so we can track them easily... right now we have more than 20 rewards panel and their order never changes, depend on post count or reputation count it takes you out of one group and puts you into another one... but it is hard to keep track of them when something unexpected happens...

[baris]

@crazycells Yeah that should be possible, https://github.com/NodeBB/NodeBB/issues/12158

[crazycells]

@baris thanks