January 2023 Developer Update

[baris]

It might be because you are adding your element after harmony javascript executes? In that case you will have to manually create the tooltip like in the harmony.js file.

[phenomlab]

@baris yes, good point. I'll figure it out.

[baris]

Pushed a new update of the theme here.

• Delete draft confirm modal and loading placeholders
• Fixed composer preview pane not overflowing properly
• Upload button in chats
• Don't focus category filter input on mobile
• All the account pages now use a shared header/footer, visibly nothing should change but let us know if you encounter any issues since it required a big refactor server side.

[Kosiak]

@Kosiak said in January 2023 Developer Update:

Issue with Сyrillic font on Mac OS:

Sill not fixed font

[baris]

@Kosiak Can you clear your cache and refresh? Let us know if it looks better.

[Kosiak]

@baris
Of course I tried in incognito mode without a cache. Font rendering is not correct for Brave (Chromium) and Firefox browsers. For Safari, the Roboto font is displayed in this place.
For all other text and interface, system font is used.

[julian]

@Kosiak you're not getting any custom fonts at all?

[Kosiak]

@julian I have disabled all non-system-protected fonts (not sure if this is correct and this situation is not the default for Mac OS Catalina) and now this panel seems to use "Helvetica Neue" too. However, the situation in which the fonts in this panel are somehow different from the fonts on the rest of the site and change due to unpredictable external conditions does not seem correct to me. If Sherif appeared on the entire site, then there would be an obvious problem of missing or conflicting system fonts, but now I don’t even know. And I don't understand Bootstrap to understand what's wrong. I'd like to try a clean install of Mac OS with standard fonts out of the box, but I don't have time for that right now.

[exodo]

Why all is so big on new theme mobile?

[julian]

@exodo everything? Somethings are bigger, yes... font size in general is at least 2px larger, but that's part of the re-design.

[baris]

Added a new setting to theme settings. You can now auto hide the bottom bar on mobile to open up some more space like persona's auto hiding top bar.

[exodo]

@julian said in January 2023 Developer Update:

@exodo everything? Somethings are bigger, yes... font size in general is at least 2px larger, but that's part of the re-design.

The thread slider was so big yesterday, i see you changed it today. Way better.

Topic listing font is very big. I can barely see only 4 topics title at same time

Will be nice if you add font size personalization for the main options

[julian]

@exodo that may be a bit of an exaggeration no? I'm comparing my phone with this site and try.nodebb.org.

The former (Harmony) displays 8 topics, the latter (Persona) can display 9.

The font sizes are controlled via a single variable on the theme side now, so it is trivial to change it for different sites, but I don't think we can make it user configurable easily.

[baris]

@exodo are you using chrome on mobile? And have you changed your font size/display size settings. I noticed an issue with chrome on mobile a while back. It is filed here https://github.com/NodeBB/NodeBB/issues/11151. Sometimes font sizes are all whacked up on chrome, doesn't happen on firefox. Left is when it's working fine, right is when it goes

[julian]

@baris yikes

[baris]

@julian haha yup, it's all fine if you don't change the font size/display size in android settings. With the default settings it looks fine and doesn't change randomly.

[exodo]

@baris said in January 2023 Developer Update:

@exodo are you using chrome on mobile? And have you changed your font size/display size settings. I noticed an issue with chrome on mobile a while back. It is filed here https://github.com/NodeBB/NodeBB/issues/11151. Sometimes font sizes are all whacked up on chrome, doesn't happen on firefox. Left is when it's working fine, right is when it goes

I use safari on ios. Last ios and last iphone. I see it like the right one

Same on chrome
I dont have any size display or font changed

[Kosiak]

Last Safari and iOS

[exodo]


[baris]

@exodo @Kosiak let us know how it looks now, we are testing some custom css here to disable font scaling done by the browsers. https://stackoverflow.com/questions/13430897/how-to-override-font-boosting-in-mobile-chrome. I've applied the below custom css and it fixes the issue I am having on android chrome. Without the max-height rule android chrome just scales text for me.

body * {
    max-height:1000000px;
    text-size-adjust: none;
    -webkit-text-size-adjust: none;
    -moz-text-size-adjust: none;
}