Unsolved Which breaking change broke post messages API?

[djensen47]

I was running NodeBB 16.x and recently updated to 17.x → 18.x → 19.x and somewhere along the way the API that TripleA (board game software that posts to my forum) uses had a breaking change. Looking through the changelog, I can't figure out which change it was.

For reference here's the issue on TripleA. The stack trace may not be useful here but just in case..

https://github.com/triplea-game/triplea/issues/10032

tripleabuilderbot created this issue in triplea-game/triplea

closed 2.5.22294: NodeBbForumPoster#uploadSaveGame:163 - java.lang.ClassCastException #10032

[PitaJ]

Looks like an API changed from returning a list to returning a map.

https://github.com/triplea-game/triplea/blob/85a52f8c238ab02adc6177a8adc5a7eea6a25c69/game-app/game-core/src/main/java/games/strategy/engine/posted/game/pbf/NodeBbForumPoster.java#L144

/api/v2/util/upload

[PitaJ]

Found your breaking change:

https://github.com/NodeBB/NodeBB/blob/master/CHANGELOG.md#breaking-changes-3

remove deprecated v2 style responses for thumbs upload route [breaking] (84dfdfe6)

https://github.com/NodeBB/NodeBB/commit/84dfdfe6

Here are @julian's notes on the matter: https://community.nodebb.org/post/81238

0 julianlam committed to NodeBB/NodeBB

chore: remove deprecated v2 style responses for thumbs upload route [breaking]

[djensen47]

@pitaj Awesome, thank you!