Block composer during upload/resize

klockprat

Is there any way to block the composer (default) to not enable the user to submit the post during upload/resizing of images

I get a few posts in the forum with the upload text instead of the real image. Would be great if the submit button was disabled until the upload and resize was done - or if the tag was updated first, and the upload/resize would continue in the background

PitaJ

That's a good suggestion. Do you mind requesting this feature on our GitHub page?

klockprat

@pitaj said in Block composer during upload/resize:

That's a good suggestion. Do you mind requesting this feature on our GitHub page?

Done, as issue #9587

<baris>

I thought we already did this. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer.js#L668

Are you able to submit the post while a big upload is still going?

klockprat

This post is deleted!

klockprat

@baris said in Block composer during upload/resize:

I thought we already did this. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer.js#L668

Can you able to submit the post while a big upload is still going?

I have seen users post with the percentage showing, but now when I try I can't...

Tried again with several photos, and then it failed

PitaJ

So you can still submit while multiple photos are uploading?

<baris>

Maybe it's a bug with the code that replaces the progress text with the actual filename. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer/uploads.js#L234-L248

So the upload is successful and it lets you submit the post but if the above code fails it won't replace the Upload 100% with the url of the image.

When you reproduce this please check the network tab for the upload request and check if the file was uploaded in your public/uploads folder.

klockprat

@pitaj said in Block composer during upload/resize:

So you can still submit while multiple photos are uploading?

Yes - or at least when I tried the last time, the upload showed 100%, but the tags were not replaced with the "resize". So maybe the upload was finished, but not the resize?

@baris said in Block composer during upload/resize:

Maybe it's a bug with the code that replaces the progress text with the actual filename. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer/uploads.js#L234-L248

So the upload is successful and it lets you submit the post but if the above code fails it won't replace the Upload 100% with the url of the image.

When you reproduce this please check the network tab for the upload request and check if the file was uploaded in your public/uploads folder.

The uploads do not end up in the /uploads/files/ folder.

I'm using the hosted solution of nodeBB, and am of course happy to help debug further!