[nodebb-plugin-poll] Poll plugin

[Scuzz]

@a_5mith So @Schamper has time to go on Github but not his own forum...

[Schamper]

@Scuzz got a mail about it, I don't have a lot of time on wifi, just small amounts of time in shops etc, which I usually use to read mail and chat with gf/family. Just checked this forum because I had extra time after dinner. I will return in about a week and you'll find me lurking in the shoutbox again then

[Scuzz]

I thought i was your gf

[julian]

hahaha I wish I could merge code using the GitHub app.. although that would be quite irresponsible for GitHub to do...

Because then people would be blindly merging without testing code

[Netto Hikari]

This question might be a bit stupid, but I actually never worked with GitHub before (created my first GitHub account a few days ago to file an issue)... I translated the plugin into German language and I'd like to file a pull request. How would I do that?

[julian]

Ah, it would be up to the individual plugin to use language strings... I'm not entirely sure on the process. @psychobunny ?

[Schamper]

@Scuzz said:

I thought i was your gf

You are too, I will make it up to you when I get back home

[psychobunny]

@julian said:

Ah, it would be up to the individual plugin to use language strings... I'm not entirely sure on the process. @psychobunny ?

Missed this. Have a look here for a sample plugin that uses i8n

EDIT: You'd have to file a PR to make it i8n compatible as well Here is the relevant line in plugin.json, and then of course you just have to move the hardcoded english strings into a en_GB folder

[chas]

it doesnt work on my forum (latest master)

if i make a poll, it instantly crashes and outputs

11/2 17:37 [24613] - error: TypeError: undefined is not a function
at /home/chas/nbb/nodebb/src/database/redis/list.js:12:4
at try_callback (/home/chas/nbb/nodebb/node_modules/redis/index.js:573:9)
at RedisClient.return_reply (/home/chas/nbb/nodebb/node_modules/redis/index.js:661:13)
at ReplyParser.<anonymous> (/home/chas/nbb/nodebb/node_modules/redis/index.js:309:14)
at ReplyParser.EventEmitter.emit (events.js:95:17)
at ReplyParser.send_reply (/home/chas/nbb/nodebb/node_modules/redis/lib/parser/javascript.js:300:10)
at ReplyParser.execute (/home/chas/nbb/nodebb/node_modules/redis/lib/parser/javascript.js:189:22)
at RedisClient.on_data (/home/chas/nbb/nodebb/node_modules/redis/index.js:534:27)
at Socket.<anonymous> (/home/chas/nbb/nodebb/node_modules/redis/index.js:91:14)
at Socket.EventEmitter.emit (events.js:95:17)
[cluster] Child Process (24613) has exited (code: 1, signal: null)
[cluster] Spinning up another process...

how come it works fine on this forum? :S

[Mega]

@chas Probably it's because of that line
https://github.com/Schamper/nodebb-plugin-poll/blob/master/lib/backend.js#L40
a callback should be passed there, but there is no.

[baris]

Latest master won't crash if callback isn't supplied.

dont crash if callback isnt supplied to list methods · NodeBB/NodeBB@749ce5f

Node.js based forum software built for the modern web - dont crash if callback isnt supplied to list methods · NodeBB/NodeBB@749ce5f

GitHub (github.com)

[Schamper]

I swear I'll update this soon Just have to finish a large report in the next 1.5 weeks and I'll have spare time for plugin development

[JonDoe12]

Any update on this @Schamper ?

[Bobber]

@Schamper Please add Russian Language Support during Poll creation UI

[Gordon Gu]

@psychobunny I tried to localize the poll plugin, but the translation doesn't happen (nodebb v0.6.x). I saw the client side js use window.templates.parse(pathToTpl, data, callback ) to process the tpl and translate string such as "[[poll.votes]]" not being replaced. Any suggestion? I guess tpl translation only happens at server side code?

[yariplus]

I got the translator working by using a ':' to split the translation filename and variable, e.g.:

"[[poll:votes]]"

and my languages/ru/poll.json has:

{
 "votes": "голосов"
}

[Gordon Gu]

@yariplus what the string to put in the tpl? I tried following:

<a class="poll-view-result-votecount" href="#">{options.votecount} [[poll:votes]]</a>

but translator didn't work:(

[yariplus]

I have

<a class="poll-view-result-votecount" href="#"> "[[poll:votes]]"</a>

(without the quotes)

[yariplus]

err, it keeps parsing out the text

This is what i'm using
https://gist.github.com/yariplus/8fbed0308828c980e117

[Gordon Gu]

@yariplus said:

gist:8fbed0308828c980e117

GitHub Gist: instantly share code, notes, and snippets.

Gist (gist.github.com)

no luck:(

my poll.json

The result