[nodebb-plugin-poll] Poll plugin
-
@Ted Browsing code on github from an iPad is painful. The actual code itself was simple enough, but finding it, not so much. I also had to test it worked on my development server first, can't go blindly submitting pull requests.
Plus, knowing my iPad, it would have auto corrected toFixed to something like tomorrow.
EDIT: PR has been merged, he's currently on holiday. (Probably Github camp by the speed he accepted the PR
) -
@a_5mith You might check out http://thebinaryapp.com/ . A friend of mine uses it and loves it. Technically in beta for the time being though.
-
@Ted said:
@a_5mith You might check out http://thebinaryapp.com/ . A friend of mine uses it and loves it. Technically in beta for the time being though.
Submitted for a key, I do own a keyboard for my iPad, albeit a Kensington, not an Apple one, but looks like it could be useful, I do a lot of travelling, so using a 17 inch laptop on a table on the train isn't always exactly possible. :laughing;
-
@Scuzz got a mail about it, I don't have a lot of time on wifi, just small amounts of time in shops etc, which I usually use to read mail and chat with gf/family. Just checked this forum because I had extra time after dinner. I will return in about a week and you'll find me lurking in the shoutbox again then
-
This question might be a bit stupid, but I actually never worked with GitHub before (created my first GitHub account a few days ago to file an issue)... I translated the plugin into German language and I'd like to file a pull request. How would I do that?
-
@julian said:
Ah, it would be up to the individual plugin to use language strings... I'm not entirely sure on the process. @psychobunny ?
Missed this. Have a look here for a sample plugin that uses i8n
EDIT: You'd have to file a PR to make it i8n compatible as well
Here is the relevant line in plugin.json, and then of course you just have to move the hardcoded english strings into a en_GBfolder -
it doesnt work on my forum (latest master)
if i make a poll, it instantly crashes and outputs
11/2 17:37 [24613] - error: TypeError: undefined is not a function
at /home/chas/nbb/nodebb/src/database/redis/list.js:12:4
at try_callback (/home/chas/nbb/nodebb/node_modules/redis/index.js:573:9)
at RedisClient.return_reply (/home/chas/nbb/nodebb/node_modules/redis/index.js:661:13)
at ReplyParser.<anonymous> (/home/chas/nbb/nodebb/node_modules/redis/index.js:309:14)
at ReplyParser.EventEmitter.emit (events.js:95:17)
at ReplyParser.send_reply (/home/chas/nbb/nodebb/node_modules/redis/lib/parser/javascript.js:300:10)
at ReplyParser.execute (/home/chas/nbb/nodebb/node_modules/redis/lib/parser/javascript.js:189:22)
at RedisClient.on_data (/home/chas/nbb/nodebb/node_modules/redis/index.js:534:27)
at Socket.<anonymous> (/home/chas/nbb/nodebb/node_modules/redis/index.js:91:14)
at Socket.EventEmitter.emit (events.js:95:17)
[cluster] Child Process (24613) has exited (code: 1, signal: null)
[cluster] Spinning up another process...how come it works fine on this forum? :S
-
@chas Probably it's because of that line
https://github.com/Schamper/nodebb-plugin-poll/blob/master/lib/backend.js#L40
a callback should be passed there, but there is no. -
Latest master won't crash if callback isn't supplied.
dont crash if callback isnt supplied to list methods Β· NodeBB/NodeBB@749ce5f
Node.js based forum software built for the modern web - dont crash if callback isnt supplied to list methods Β· NodeBB/NodeBB@749ce5f
GitHub (github.com)
-
I swear I'll update this soon
Just have to finish a large report in the next 1.5 weeks and I'll have spare time for plugin development 
-
@psychobunny I tried to localize the poll plugin, but the translation doesn't happen (nodebb v0.6.x). I saw the client side js use window.templates.parse(pathToTpl, data, callback ) to process the tpl and translate string such as "[[poll.votes]]" not being replaced. Any suggestion? I guess tpl translation only happens at server side code?
