Updating emoji plugin to 3.5.0 breaks categories view

dcook

@PitaJ I was able to disable the emoji plugin, but the the categories link is still showing the error page:

Every other link in the menu works fine, its only categories that is broken, however since I have that set as the homepage its causing big issues.

2021-03-13T20:54:55.150Z [4567/1830] - error: /categories
TypeError: Object.fromEntries is not a function
    at Object.parse [as default] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parse.ts:41:26)
    at parseRaw (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:20:22)
    at Object.parsePost [as method] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:34:28)
    at /home/tirpc/nodebb/src/plugins/hooks.js:129:28
    at eachOfSeries$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:1631:13)
    at replenish (/home/tirpc/nodebb/node_modules/async/dist/async.js:440:21)
    at /home/tirpc/nodebb/node_modules/async/dist/async.js:445:13
    at eachOfLimit$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:471:34)
    at awaitable (/home/tirpc/nodebb/node_modules/async/dist/async.js:208:32)
    at eachOfSeries (/home/tirpc/nodebb/node_modules/async/dist/async.js:658:16)
2021-03-13T20:55:02.533Z [4567/1830] - error: /api/categories
TypeError: Object.fromEntries is not a function
    at Object.parse [as default] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parse.ts:41:26)
    at parseRaw (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:20:22)
    at Object.parsePost [as method] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:34:28)
    at /home/tirpc/nodebb/src/plugins/hooks.js:129:28
    at eachOfSeries$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:1631:13)
    at replenish (/home/tirpc/nodebb/node_modules/async/dist/async.js:440:21)
    at /home/tirpc/nodebb/node_modules/async/dist/async.js:445:13
    at eachOfLimit$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:471:34)
    at awaitable (/home/tirpc/nodebb/node_modules/async/dist/async.js:208:32)
    at eachOfSeries (/home/tirpc/nodebb/node_modules/async/dist/async.js:658:16)
2021-03-13T20:56:10.444Z [4567/1830] - error: /api/categories
TypeError: Object.fromEntries is not a function
    at Object.parse [as default] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parse.ts:41:26)
    at parseRaw (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:20:22)
    at Object.parsePost [as method] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:34:28)
    at /home/tirpc/nodebb/src/plugins/hooks.js:129:28
    at eachOfSeries$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:1631:13)
    at replenish (/home/tirpc/nodebb/node_modules/async/dist/async.js:440:21)
    at /home/tirpc/nodebb/node_modules/async/dist/async.js:445:13
    at eachOfLimit$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:471:34)
    at awaitable (/home/tirpc/nodebb/node_modules/async/dist/async.js:208:32)
    at eachOfSeries (/home/tirpc/nodebb/node_modules/async/dist/async.js:658:16)
2021-03-13T20:56:12.231Z [4567/1830] - error: /api/categories
TypeError: Object.fromEntries is not a function
    at Object.parse [as default] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parse.ts:41:26)
    at parseRaw (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:20:22)
    at Object.parsePost [as method] (/home/tirpc/nodebb/node_modules/nodebb-plugin-calendar/src/lib/parseFilters.ts:34:28)
    at /home/tirpc/nodebb/src/plugins/hooks.js:129:28
    at eachOfSeries$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:1631:13)
    at replenish (/home/tirpc/nodebb/node_modules/async/dist/async.js:440:21)
    at /home/tirpc/nodebb/node_modules/async/dist/async.js:445:13
    at eachOfLimit$1 (/home/tirpc/nodebb/node_modules/async/dist/async.js:471:34)
    at awaitable (/home/tirpc/nodebb/node_modules/async/dist/async.js:208:32)
    at eachOfSeries (/home/tirpc/nodebb/node_modules/async/dist/async.js:658:16)

PitaJ

@dcook what OS are you on? How did you install Node.js in the first place?

It was never the emoji plugin, but the calendar plugin (as shown in the error message). You can use the same command as before to disable it for now:

./nodebb reset -p calendar

dcook

@pitaj

Ubuntu 18.04.4 LTS \n \l

I followed these setups when I installed NodeBB several years ago:
https://docs.nodebb.org/installing/os/ubuntu/

Prior to upgrading NodeBB I always run first:
sudo apt-get update
sudo apt-get upgrade

Once the server is rebooted, I then follow these upgrade instructions:
https://docs.nodebb.org/configuring/upgrade/

Most recently I updated to 1.16.2 a couple months ago now.

It was working fine until this morning, when I logged into the ACP and seen the alert that I should upgrade the emoji plugin which I did, I then did the "Rebuild & Restart" since then, the categories has been showing the error.

PitaJ

@dcook try this is upgrade node

curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash -
sudo apt-get install -y nodejs

dcook

@pitaj said in Updating emoji plugin to 3.5.0 breaks categories view:

sudo apt-get install -y nodejs

Thanks that seemed to resolve the issue, should those commands be done as part of the NodeBB upgrade steps? As it was not mentioned in the Instructions: https://docs.nodebb.org/configuring/upgrade/

dcook

@PitaJ running those commands fixed the categories issue, but has created a new issue:

I have 2 NodeBB servers both are Ubuntu 18.04.4 and have NodeBB 1.16.2, on the server that I ran those 2 commands on:

Now whenever someone clicks on upload an image to a post, no matter what image or size of image they get: error-invalid files

On the other server that I have not run those commands on yet, upload image works normally.

/nodebb log shows:

2021-03-14T16:19:21.629Z [4567/3418] - error: /api/post/upload
Error: [[error:invalid-files]]
    at validateFiles (/home/bgc/nodebb/src/middleware/index.js:106:15)
    at Layer.handle [as handle_request] (/home/bgc/nodebb/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/bgc/nodebb/node_modules/express/lib/router/route.js:137:13)
    at Form.<anonymous> (/home/bgc/nodebb/node_modules/connect-multiparty/index.js:114:7)
    at Form.emit (events.js:315:20)
    at emitCloseNT (internal/streams/destroy.js:87:10)
    at processTicksAndRejections (internal/process/task_queues.js:79:21)
2021-03-14T16:19:30.900Z [4567/3418] - error: /api/post/upload
Error: [[error:invalid-files]]
    at validateFiles (/home/bgc/nodebb/src/middleware/index.js:106:15)
    at Layer.handle [as handle_request] (/home/bgc/nodebb/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/bgc/nodebb/node_modules/express/lib/router/route.js:137:13)
    at Form.<anonymous> (/home/bgc/nodebb/node_modules/connect-multiparty/index.js:114:7)
    at Form.emit (events.js:315:20)
    at emitCloseNT (internal/streams/destroy.js:87:10)
    at processTicksAndRejections (internal/process/task_queues.js:79:21)

<baris>

See here https://community.nodebb.org/topic/15075/nodebb-v1-15-0-rc-0-release-candidate-published/8?_=1615739118416, you need to run npm i [email protected] to update that dependency.

dcook

@baris thank you, I will try that command

I really wish you guys would get your s**t together, I shouldn't need to do all these manual steps to have working NodeBB, isn't that what ./nodebb upgrade command is supposed to do?

<baris>

Yes, but for some reason the package manager npm doesn't upgrade that dependency during ./nodebb upgrade.

I have manually added the dependency to our list maybe that will fix the issue.

https://github.com/NodeBB/NodeBB/commit/ef3ec96af235de796160ef28ad03b84b3f1b9820

PitaJ

./nodebb upgrade doesn't handle pulling the latest code from git, nor does it handle upgrading system packages like Node.

dcook

@pitaj Prior to running ./nodebb upgrade I always do apt-get-update apt-get-upgrade so the server is already fully updated.

If there is something else that NodeBB requires then it should be part of the nodebb upgrade command.