upgrading from 0.7.3 - advice

Patrick Sébastien Coulombe

npm install --unsafe-perm (I had to run it manually with --unsafe-perm)

npm WARN [email protected] requires a peer of eslint@^5.16.0 || ^6.8.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of nodebb-plugin-emoji@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of nodebb-plugin-emoji@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of textcomplete@^0.14.2 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

audited 1361 packages in 3.717s

77 packages are looking for funding
  run `npm fund` for details

found 4 vulnerabilities (3 low, 1 high)
  run `npm audit fix` to fix them, or `npm audit` for details

./nodebb upgrade

Updating NodeBB...

1. Updating package.json file with defaults...  OK

2. Bringing base dependencies up to date...  started
npm WARN [email protected] requires a peer of eslint@^5.16.0 || ^6.8.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of nodebb-plugin-emoji@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of nodebb-plugin-emoji@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of textcomplete@^0.14.2 but none is installed. You must install peer dependencies yourself.

audited 1361 packages in 3.915s

77 packages are looking for funding
  run `npm fund` for details

found 4 vulnerabilities (3 low, 1 high)
  run `npm audit fix` to fix them, or `npm audit` for details

3. Checking installed plugins for updates...  OK
4. Updating NodeBB data store schema...2020-10-14T20:07:35.653Z [4567/285096] - warn: [cache-buster] could not read cache buster ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/cache-buster' {"errno":-2,"code":"ENOENT","syscall":"open","path":"/home/psc/Downloads/nodebb/build/cache-buster","stack":"Error: ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/cache-buster'"}

Parsing upgrade scripts... 
2020-10-14T20:07:35.688Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-youtube-lite`. Skipping.
2020-10-14T20:07:35.688Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-anti-spam-question`. Skipping.
2020-10-14T20:07:35.688Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-embed-videos`. Skipping.
2020-10-14T20:07:35.688Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-code-button`. Skipping.
2020-10-14T20:07:35.689Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-soundcloud`. Skipping.
2020-10-14T20:07:35.689Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-custom-pages`. Skipping.
2020-10-14T20:07:35.689Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-vimeo`. Skipping.
2020-10-14T20:07:35.689Z [4567/285096] - warn: [upgrade/appendPluginScripts] Unable to read plugin.json for plugin `nodebb-plugin-emailer-mailgun`. Skipping.
OK | 67 script(s) found, 22 skipped
  → [2017/4/16] Delete accidentally long-lived sessions...Error occurred
Error occurred during upgrade: TypeError: rdb.connect is not a function
    at /home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:26:23
    at nextTask (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4576:27)
    at Object.waterfall (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4587:9)
    at Object.awaitable [as waterfall] (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:208:32)
    at Object.method (/home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:22:9)
    at internal/util.js:297:30
    at new Promise (<anonymous>)
    at Object.method (internal/util.js:296:12)
    at /home/psc/Downloads/nodebb/src/upgrade.js:174:8
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:148:38
2020-10-14T20:07:35.692Z [4567/285096] - error: uncaughtException: rdb.connect is not a function
TypeError: rdb.connect is not a function
    at /home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:26:23
    at nextTask (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4576:27)
    at Object.waterfall (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4587:9)
    at Object.awaitable [as waterfall] (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:208:32)
    at Object.method (/home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:22:9)
    at internal/util.js:297:30
    at new Promise (<anonymous>)
    at Object.method (internal/util.js:296:12)
    at /home/psc/Downloads/nodebb/src/upgrade.js:174:8
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:148:38 {"error":{},"stack":"TypeError: rdb.connect is not a function\n    at /home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:26:23\n    at nextTask (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4576:27)\n    at Object.waterfall (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4587:9)\n    at Object.awaitable [as waterfall] (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:208:32)\n    at Object.method (/home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js:22:9)\n    at internal/util.js:297:30\n    at new Promise (<anonymous>)\n    at Object.method (internal/util.js:296:12)\n    at /home/psc/Downloads/nodebb/src/upgrade.js:174:8\n    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:148:38","exception":true,"date":"Wed Oct 14 2020 16:07:35 GMT-0400 (Eastern Daylight Time)","process":{"pid":285096,"uid":0,"gid":0,"cwd":"/home/psc/Downloads/nodebb","execPath":"/usr/local/bin/node","version":"v12.19.0","argv":["/usr/local/bin/node","/home/psc/Downloads/nodebb/nodebb","upgrade"],"memoryUsage":{"rss":138317824,"heapTotal":92753920,"heapUsed":58033752,"external":1681282,"arrayBuffers":184113}},"os":{"loadavg":[1.21,1.01,1.02],"uptime":28125},"trace":[{"column":23,"file":"/home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js","function":null,"line":26,"method":null,"native":false},{"column":27,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":"nextTask","line":4576,"method":null,"native":false},{"column":9,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":"Object.waterfall","line":4587,"method":"waterfall","native":false},{"column":32,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":"Object.awaitable [as waterfall]","line":208,"method":"awaitable [as waterfall]","native":false},{"column":9,"file":"/home/psc/Downloads/nodebb/src/upgrades/1.4.6/delete_sessions.js","function":"Object.method","line":22,"method":"method","native":false},{"column":30,"file":"internal/util.js","function":null,"line":297,"method":null,"native":false},{"column":null,"file":null,"function":"new Promise","line":null,"method":null,"native":false},{"column":12,"file":"internal/util.js","function":"Object.method","line":296,"method":"method","native":false},{"column":8,"file":"/home/psc/Downloads/nodebb/src/upgrade.js","function":null,"line":174,"method":null,"native":false},{"column":38,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":null,"line":148,"method":null,"native":false}]}

PitaJ

@patrick-sébastien-coulombe why are you running as root/sudo? unsafe-perm shouldn't be necessary.

Anyways, I think that issue is fixed in this commit: https://github.com/NodeBB/NodeBB/commit/29e3ab247d336220cdddd123fc8703a3a97b1013

So run git cherry-pick 29e3ab247d336220cdddd123fc8703a3a97b1013 to pull that fix in.

Patrick Sébastien Coulombe

@pitaj yes going a bit further

→ [2017/4/14] Set default allowed file extensions... OK
    [#############] (8700/8759) 99%  OKom uploaded profile cover urls...
  → [2017/5/26] rename user mod privileges group...Error occurred
Error occurred during upgrade: Error: ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/public/templates/admin/partials/widget-settings.tpl'
2020-10-14T20:40:07.011Z [4567/307201] - error: uncaughtException: ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/public/templates/admin/partials/widget-settings.tpl'
Error: ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/public/templates/admin/partials/widget-settings.tpl' {"error":{"errno":-2,"code":"ENOENT","syscall":"open","path":"/home/psc/Downloads/nodebb/build/public/templates/admin/partials/widget-settings.tpl"},"stack":"Error: ENOENT: no such file or directory, open '/home/psc/Downloads/nodebb/build/public/templates/admin/partials/widget-settings.tpl'","exception":true,"date":"Wed Oct 14 2020 16:40:07 GMT-0400 (Eastern Daylight Time)","process":{"pid":307201,"uid":0,"gid":0,"cwd":"/home/psc/Downloads/nodebb","execPath":"/usr/local/bin/node","version":"v12.19.0","argv":["/usr/local/bin/node","/home/psc/Downloads/nodebb/nodebb","upgrade"],"memoryUsage":{"rss":278552576,"heapTotal":225935360,"heapUsed":202771344,"external":2048776,"arrayBuffers":551607}},"os":{"loadavg":[0.58,0.84,0.98],"uptime":30076},"trace":[]}

PitaJ

@patrick-sébastien-coulombe try running ./nodebb build (hopefully it'll complete successfully, if not show the errors here) then re-running the upgrade again.

Patrick Sébastien Coulombe

@pitaj Closer and closer! Schema update complete! but failing at step 5.

  → [2019/1/21] Enable StopForumSpam by default without api key... OK
Schema update complete!


5. Rebuilding assets...  started
2020-10-14T21:57:29.523Z [4567/350261] - error: uncaughtException: callback is not a function
TypeError: callback is not a function
    at /home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js:41:5
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:321:20
    at next (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4450:29)
    at /home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js:25:14
    at /home/psc/Downloads/nodebb/src/promisify.js:46:48
    at cb (util.js:207:31)
    at util.js:191:10
    at hidden (internal/errors.js:290:14)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {"error":{},"stack":"TypeError: callback is not a function\n    at /home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js:41:5\n    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:321:20\n    at next (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:4450:29)\n    at /home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js:25:14\n    at /home/psc/Downloads/nodebb/src/promisify.js:46:48\n    at cb (util.js:207:31)\n    at util.js:191:10\n    at hidden (internal/errors.js:290:14)\n    at processTicksAndRejections (internal/process/task_queues.js:84:21)","exception":true,"date":"Wed Oct 14 2020 17:57:29 GMT-0400 (Eastern Daylight Time)","process":{"pid":350261,"uid":0,"gid":0,"cwd":"/home/psc/Downloads/nodebb","execPath":"/usr/local/bin/node","version":"v12.19.0","argv":["/usr/local/bin/node","/home/psc/Downloads/nodebb/nodebb","upgrade"],"memoryUsage":{"rss":264130560,"heapTotal":192598016,"heapUsed":96301608,"external":2916871,"arrayBuffers":1419702}},"os":{"loadavg":[1.71,0.74,0.42],"uptime":34719},"trace":[{"column":5,"file":"/home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js","function":null,"line":41,"method":null,"native":false},{"column":20,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":null,"line":321,"method":null,"native":false},{"column":29,"file":"/home/psc/Downloads/nodebb/node_modules/async/dist/async.js","function":"next","line":4450,"method":null,"native":false},{"column":14,"file":"/home/psc/Downloads/nodebb/src/upgrades/1.12.1/clear_username_email_history.js","function":null,"line":25,"method":null,"native":false},{"column":48,"file":"/home/psc/Downloads/nodebb/src/promisify.js","function":null,"line":46,"method":null,"native":false},{"column":31,"file":"util.js","function":"cb","line":207,"method":null,"native":false},{"column":10,"file":"util.js","function":null,"line":191,"method":null,"native":false},{"column":14,"file":"internal/errors.js","function":"hidden","line":290,"method":null,"native":false},{"column":21,"file":"internal/process/task_queues.js","function":"processTicksAndRejections","line":84,"method":null,"native":false}]}
2020-10-14T21:57:29.535Z [4567/350261] - info: [build] Building in parallel mode
2020-10-14T21:57:29.536Z [4567/350261] - info: [build]         plugin static dirs  build started
2020-10-14T21:57:29.537Z [4567/350261] - info: [build]          requirejs modules  build started
2020-10-14T21:57:29.537Z [4567/350261] - info: [build]           client js bundle  build started
2020-10-14T21:57:29.537Z [4567/350261] - info: [build]            admin js bundle  build started
2020-10-14T21:57:29.538Z [4567/350261] - info: [build]         client side styles  build started
2020-10-14T21:57:29.538Z [4567/350261] - info: [build] admin control panel styles  build started
2020-10-14T21:57:29.538Z [4567/350261] - info: [build]                  templates  build started
2020-10-14T21:57:29.539Z [4567/350261] - info: [build]                  languages  build started
2020-10-14T21:57:29.539Z [4567/350261] - info: [build]                     sounds  build started
2020-10-14T21:57:29.879Z [4567/350261] - info: [build]                     sounds  build completed in 0.34sec
2020-10-14T21:57:29.900Z [4567/350261] - info: [build]         plugin static dirs  build completed in 0.364sec
root@ideapad:/home/psc/Downloads/nodebb# events.js:291
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at process.target.send (internal/child_process.js:679:16)
    at /home/psc/Downloads/nodebb/src/meta/minifier.js:125:13
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:2955:19
    at wrapper (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:268:20)
    at iteratorCallback (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:495:17)
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:321:20
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:2953:17
    at /home/psc/Downloads/nodebb/node_modules/graceful-fs/graceful-fs.js:144:16
    at /home/psc/Downloads/nodebb/node_modules/graceful-fs/graceful-fs.js:61:14
    at FSReqCallback.oncomplete (fs.js:156:23)
Emitted 'error' event on process instance at:
    at internal/child_process.js:683:35
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 'ERR_IPC_CHANNEL_CLOSED'
}
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at process.target.send (internal/child_process.js:679:16)
    at /home/psc/Downloads/nodebb/src/meta/minifier.js:125:13
    at wrapper (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:268:20)
    at iterateeCallback (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:421:28)
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:321:20
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:2955:19
    at wrapper (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:268:20)
    at iteratorCallback (/home/psc/Downloads/nodebb/node_modules/async/dist/async.js:495:17)
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:321:20
    at /home/psc/Downloads/nodebb/node_modules/async/dist/async.js:2953:17
Emitted 'error' event on process instance at:
    at internal/child_process.js:683:35
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 'ERR_IPC_CHANNEL_CLOSED'
}
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at process.target._send (internal/child_process.js:806:20)
    at process.target.send (internal/child_process.js:677:19)
    at /home/psc/Downloads/nodebb/src/meta/minifier.js:125:13
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
Emitted 'error' event on process instance at:
    at internal/child_process.js:810:39
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  errno: 'EPIPE',
  code: 'EPIPE',
  syscall: 'write'
}
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at process.target._send (internal/child_process.js:806:20)
    at process.target.send (internal/child_process.js:677:19)
    at /home/psc/Downloads/nodebb/src/meta/minifier.js:125:13
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
Emitted 'error' event on process instance at:
    at internal/child_process.js:810:39
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  errno: 'EPIPE',
  code: 'EPIPE',
  syscall: 'write'
}

PitaJ

@patrick-sébastien-coulombe do you get that when you re-run it?

Patrick Sébastien Coulombe

@pitaj No (it works)! What version is recommended for nodejs. I am using v12 should I use v10?

PitaJ

@patrick-sébastien-coulombe NodeBB v1.14.x supports:

Node 10
Node 12
Node 14

It's recommended you use the latest LTS (even versions), so in this case that would Node 14.

Patrick Sébastien Coulombe

@pitaj Fantastic. The main problem now is with the url, clicking on the menu categorie (or any icon ithe menu). How bad is it?

PitaJ

@patrick-sébastien-coulombe that appears to be this issue, which doesn't seem to be fixed yet.

https://community.nodebb.org/topic/14932/strange-thing-in-navigation-urls/6

You should be able to fix it, at least temporarily, by modifying them manually in the ACP. Name should be [[global:header.categories]]