username length problems
-
When people sign up using SSO, they can have username with longer than 16 characters, but when these users try to edit their profile they keep getting 'username too long' error...
Since they cannot edit their username afterwards, they should either get this error while signing up, or should be able to edit their profile without error.
Btw, this is not about 1.13, we still could not upgrade yet, we are still on 1.12.2 , fyi.
-
@crazycells The maximum username length is governed by a field in the ACP. If SSO signs up users with longer usernames, then you could always adjust the value to match restrictions from the SSO.
-
@julian said in username length problems:
@crazycells The maximum username length is governed by a field in the ACP. If SSO signs up users with longer usernames, then you could always adjust the value to match restrictions from the SSO.
That is already set in ACP; but apparently SSOs (it was facebook in this case) are letting usernames with more than set length.
I want this to be adjusted while users are signing up (by SSO asking user to shorten username), so we do not have to change their usernames later.
-
Then you will probably have to modify the sso plugin to reject or truncate usernames that are too long.
I'm not sure if NodeBB should reject things like creating an user by a plugin if the plugin doesn't adhere to admin settings, because there might be valid reasons for doing it. For example - you might have a username length limit, because you want to reserve longer usernames for bot users created by a plugin or something.
-
unfortunately, this problem continues...
Although username length is set in ACP, SSO plugin registrations are kept exempt... and these users are always having errors while trying to edit their profile.
-
That's weird, when I lower the max username setting to 14 and login with a user who has a long username (21 characters in this case) I can still edit my profile and add location/fullname etc.
Are they getting an error when updating the profile fields or when trying to change the username?
-
@baris said in username length problems:
That's weird, when I lower the max username setting to 14 and login with a user who has a long username (21 characters in this case) I can still edit my profile and add location/fullname etc.
Are they getting an error when updating the profile fields or when trying to change the username?
I will ask but it should be during updating the profile because unfortunately, they cannot change their usernames after the registration. They can only do so during registration.
-
Hi @baris , I started to see new users with two-character usernames in our forum. Our settings prevent less than 3 characters usernames however these people can bypass this requirement by SSO registration (especially google SSO in this case).
Is this a bug? or intended behavior?
-
-
@baris said in username length problems:
Seems like sso plugins do not check if the username is shorter than the forum minimum. You can open an issue on github.
should I open it on NodeBB main GH? or for each SSO plugin GH individually?
