New features for nodebb-plugin-reactions

[eshohet]

Hi all,

I really like the concept of being able to react to a person's post, so I've decided to maintain plugin since it recently broke.

You can find my repo here:
https://github.com/eshohet/nodebb-plugin-reactions

I added emoji.json to the repo, since it was not able to find it otherwise. I realize this is incorrect and would appreciate help fixing it.

I also added notifications so that when someone reacts to your post, you'll get a notification about it.

Thanks,

Elliot

[PitaJ]

@elliot the existing nodebb-plugin-reactions version 0.0.3 works with the latest NodeBB afaik. It requires nodebb-plugin-emoji v2.

Have you considered sending a pull request to the original repo for the notifications etc?

[eshohet]

@pitaj said in New features for nodebb-plugin-reactions:

@elliot the existing nodebb-plugin-reactions version 0.0.3 works with the latest NodeBB afaik. It requires nodebb-plugin-emoji v2.

Have you considered sending a pull request to the original repo for the notifications etc?

I'll have to look into v2.
I haven't, wanted to clean things up properly before submitting a PR. This is my first time modifying a plugin, so feedback on the code would be ideal - I don't want to break things.

[faizanzahid]

@pitaj said in New features for nodebb-plugin-reactions:

-plugin-reactions version 0.0.3 wor

i'd be interested if this plugin works with node bb 1.9.2 fully! we like this plugin

[eshohet]

@pitaj said in New features for nodebb-plugin-reactions:

nodebb-plugin-emoji v2.

@PitaJ Can you link me to the latest version? There are many versions - I don't know which one to work with.

Working on a PR now.

[PitaJ]

@elliot

GitHub - NodeBB/nodebb-plugin-emoji: NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com

NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com - GitHub - NodeBB/nodebb-plugin-emoji: NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com

GitHub (github.com)

[eshohet]

@pitaj said in New features for nodebb-plugin-reactions:

@elliot

GitHub - NodeBB/nodebb-plugin-emoji: NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com

NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com - GitHub - NodeBB/nodebb-plugin-emoji: NodeBB Plugin enabling emoji as seen on http://www.emoji-cheat-sheet.com

GitHub (github.com)

I have this version but have a strange bug:

Is this due to nodebb-plugin-reactions or the emoji plugin?

[PitaJ]

@elliot are you using a bootswatch skin or a theme other than persona? Let me know which one if you are.

[eshohet]

@PitaJ I'm using the slick theme.